2013-06-01 10:00:00

by Thomas Meyer

Subject: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"

Signed-off-by: Thomas Meyer <[email protected]>
---

diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct

core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
"sas_queue_%d", core->shost->host_no);
- if (IS_ERR(core->queue_thread))
- return PTR_ERR(core->queue_thread);
- return 0;
+ return PTR_RET(core->queue_thread);
}

void sas_shutdown_queue(struct sas_ha_struct *sas_ha)

2013-06-01 15:26:53

by James Bottomley

Subject: Re: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"

On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <[email protected]>
> ---
>
> diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
>
> core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
> "sas_queue_%d", core->shost->host_no);
> - if (IS_ERR(core->queue_thread))
> - return PTR_ERR(core->queue_thread);
> - return 0;
> + return PTR_RET(core->queue_thread);
> }

Really, no, this is not a good patch. I know exactly what the current
code is doing by reading it. With your patch I now have to go and look
up the definition of an obscure and non-standard macro.

If we're sacrificing clarity, I want a good reason and having two lines
fewer code isn't it.

James