2013-06-04 08:06:35

by Li Guang

Subject: [PATCH 1/2] acpi/processor: remove bm_rld_set of acpi_processor_flags

bm_rld_set seems obsolete now

Signed-off-by: liguang <[email protected]>
---
include/acpi/processor.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index ea69367..cfec509 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -188,7 +188,6 @@ struct acpi_processor_flags {
u8 bm_check:1;
u8 has_cst:1;
u8 power_setup_done:1;
- u8 bm_rld_set:1;
u8 need_hotplug_init:1;
};

--
1.7.2.5

2013-06-04 08:06:47

by Li Guang

Subject: [PATCH 2/2] xen: remove bm_rld_set of xen_processor_flags

bm_rld_set seems obsolete now

Signed-off-by: liguang <[email protected]>
---
include/xen/interface/platform.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/xen/interface/platform.h b/include/xen/interface/platform.h
index c57d5f6..7ffff33 100644
--- a/include/xen/interface/platform.h
+++ b/include/xen/interface/platform.h
@@ -240,7 +240,6 @@ struct xen_processor_flags {
uint32_t bm_check:1;
uint32_t has_cst:1;
uint32_t power_setup_done:1;
- uint32_t bm_rld_set:1;
};

struct xen_processor_power {
--
1.7.2.5

2013-06-04 08:13:37

by Jan Beulich

Subject: Re: [PATCH 2/2] xen: remove bm_rld_set of xen_processor_flags

>>> On 04.06.13 at 10:05, liguang <[email protected]> wrote:
> bm_rld_set seems obsolete now
>
> Signed-off-by: liguang <[email protected]>
> ---
> include/xen/interface/platform.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/xen/interface/platform.h
> b/include/xen/interface/platform.h
> index c57d5f6..7ffff33 100644
> --- a/include/xen/interface/platform.h
> +++ b/include/xen/interface/platform.h
> @@ -240,7 +240,6 @@ struct xen_processor_flags {
> uint32_t bm_check:1;
> uint32_t has_cst:1;
> uint32_t power_setup_done:1;
> - uint32_t bm_rld_set:1;
> };
>
> struct xen_processor_power {

Any such patch would need to be submitted against the master copy
of the header (in the Xen repo), and by recognizing that you'd also
notice that this is part of a public ABI, and hence can't be removed,
but at best can be documented as obsolete. Of course you'd first
need to check whether the hypervisor makes any use of that bit
when passed down from Dom0.

Jan

2013-06-04 08:20:28

by Li Guang

Subject: Re: [PATCH 2/2] xen: remove bm_rld_set of xen_processor_flags

在 2013-06-04二的 09:13 +0100，Jan Beulich写道：
> >>> On 04.06.13 at 10:05, liguang <[email protected]> wrote:
> > bm_rld_set seems obsolete now
> >
> > Signed-off-by: liguang <[email protected]>
> > ---
> > include/xen/interface/platform.h | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/xen/interface/platform.h
> > b/include/xen/interface/platform.h
> > index c57d5f6..7ffff33 100644
> > --- a/include/xen/interface/platform.h
> > +++ b/include/xen/interface/platform.h
> > @@ -240,7 +240,6 @@ struct xen_processor_flags {
> > uint32_t bm_check:1;
> > uint32_t has_cst:1;
> > uint32_t power_setup_done:1;
> > - uint32_t bm_rld_set:1;
> > };
> >
> > struct xen_processor_power {
>
> Any such patch would need to be submitted against the master copy
> of the header (in the Xen repo), and by recognizing that you'd also
> notice that this is part of a public ABI, and hence can't be removed,
> but at best can be documented as obsolete. Of course you'd first
> need to check whether the hypervisor makes any use of that bit
> when passed down from Dom0.
>

Right, this patch mostly likes a reminder,
hoping someone will try it and verify it's fail or OK,
since I can't test this for now.

Sorry and Thanks!