2013-06-06 21:40:10

by Nicolas Palix (LIG)

Subject: [PATCH 1/2] Coccinelle: Make 'report' the default mode

It appears that the 'report' mode is the one always
provided by the semantic patches included in the kernel.
It is thus more natural to select it by default.

The 'chain' mode is however kept and the 'patch' mode
is still the first tried in that case.

Signed-off-by: Nicolas Palix <[email protected]>
---

I forgot to sign the previous emails.

scripts/coccicheck | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 06fcb33..9d8780c 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -44,11 +44,19 @@ fi

if [ "$MODE" = "" ] ; then
if [ "$ONLINE" = "0" ] ; then
- echo 'You have not explicitly specified the mode to use. Using default "chain" mode.'
- echo 'All available modes will be tried (in that order): patch, report, context, org'
+ echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
+ echo 'Available modes are the following: patch, report, context, org'
echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
+ echo 'Note however that some modes are not implemented by some semantic patches.'
+ fi
+ MODE="report"
+fi
+
+if [ "$MODE" = "chain" ] ; then
+ if [ "$ONLINE" = "0" ] ; then
+ echo 'You have selected the "chain" mode.'
+ echo 'All available modes will be tried (in that order): patch, report, context, org'
fi
- MODE="chain"
elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
FLAGS="$FLAGS -no_show_diff"
fi
--
1.8.1.2

2013-06-06 21:40:14

by Nicolas Palix (LIG)

Subject: [PATCH 2/2] Coccinelle: Update the Coccinelle section of MAINTAINERS

Add Michal Marek and the misc branch of the kbuild tree
in the Coccinelle section of MAINTAINERS.

Signed-off-by: Nicolas Palix <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3d7782b..73b1b3a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2098,7 +2098,9 @@ COCCINELLE/Semantic Patches (SmPL)
M: Julia Lawall <[email protected]>
M: Gilles Muller <[email protected]>
M: Nicolas Palix <[email protected]>
+M: Michal Marek <[email protected]>
L: [email protected] (moderated for non-subscribers)
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git misc
W: http://coccinelle.lip6.fr/
S: Supported
F: scripts/coccinelle/
--
1.8.1.2

2013-06-14 13:33:01

by Michal Marek

Subject: Re: [PATCH 1/2] Coccinelle: Make 'report' the default mode

On Thu, Jun 06, 2013 at 11:39:52PM +0200, Nicolas Palix wrote:
> It appears that the 'report' mode is the one always
> provided by the semantic patches included in the kernel.
> It is thus more natural to select it by default.
>
> The 'chain' mode is however kept and the 'patch' mode
> is still the first tried in that case.
>
> Signed-off-by: Nicolas Palix <[email protected]>

On Thu, Jun 06, 2013 at 11:39:53PM +0200, Nicolas Palix wrote:
> Add Michal Marek and the misc branch of the kbuild tree
> in the Coccinelle section of MAINTAINERS.
>
> Signed-off-by: Nicolas Palix <[email protected]>

I applied both patches to kbuild.git#misc.

Thanks,
Michal