2013-06-10 14:48:06

by Alexander Shiyan

Subject: [PATCH] Misc: sram: Remove unneeded check

Patch removes unneeded check for resource since
devm_ioremap_resource do all for us.

Signed-off-by: Alexander Shiyan <[email protected]>
---
drivers/misc/sram.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
index 4a93886..d87cc91 100644
--- a/drivers/misc/sram.c
+++ b/drivers/misc/sram.c
@@ -45,15 +45,11 @@ static int sram_probe(struct platform_device *pdev)
int ret;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EINVAL;
-
- size = resource_size(res);
-
virt_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(virt_base))
return PTR_ERR(virt_base);

+ size = resource_size(res);

sram = devm_kzalloc(&pdev->dev, sizeof(*sram), GFP_KERNEL);
if (!sram)
--
1.8.1.5

2013-06-10 15:38:30

by Arnd Bergmann

Subject: Re: [PATCH] Misc: sram: Remove unneeded check

On Monday 10 June 2013, Alexander Shiyan wrote:
> Patch removes unneeded check for resource since
> devm_ioremap_resource do all for us.
>
> Signed-off-by: Alexander Shiyan <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>