tnetv107x_defconfig build failing on removal selection of NEED_MACH_GPIO_H
for ARCH_DAVINCI. This is due to header files inclusion from mach/gpio-davinci.h
So this patch series fixes the build breakage on removal of NEED_MACH_GPIO_H.
This patch series is based on Linux 3.10-rc4 and is availabel at [1] and dependency on 2.
1. https://github.com/avinashphilip/am335x_linux/tree/linux_davinci_v3.10_soc_gpio_v310-rc4
2. https://patchwork.kernel.org/patch/97853/
Philip Avinash (2):
ARM: davinci: fix for build breakage for tnetv107x platforms
gpio: gpio-tnetv107x: Fix bulid breakge
arch/arm/mach-davinci/board-tnetv107x-evm.c | 5 +++--
drivers/gpio/gpio-tnetv107x.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
1.7.9.5
Fix the following build breakage and section mismatch error. This build
break will comes only on removal of NEED_MACH_GPIO_H select option for
ARCH-DAVINCI.
arch/arm/mach-davinci/board-tnetv107x-evm.c:283:15: error:
'davinci_timer_init' undeclared here (not in a function)
arch/arm/mach-davinci/board-tnetv107x-evm.c:285:15: error:
'davinci_init_late' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-davinci/board-tnetv107x-evm.o] Error 1
Signed-off-by: Philip Avinash <[email protected]>
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c b/arch/arm/mach-davinci/board-tnetv107x-evm.c
index ba79837..b5db980 100644
--- a/arch/arm/mach-davinci/board-tnetv107x-evm.c
+++ b/arch/arm/mach-davinci/board-tnetv107x-evm.c
@@ -30,6 +30,7 @@
#include <asm/mach/arch.h>
#include <asm/mach-types.h>
+#include <mach/common.h>
#include <mach/irqs.h>
#include <mach/edma.h>
#include <mach/mux.h>
@@ -147,7 +148,7 @@ static struct davinci_nand_pdata nand_config = {
.ecc_bits = 1,
};
-static struct davinci_uart_config serial_config __initconst = {
+static struct davinci_uart_config serial_config __initdata = {
.enabled_uarts = BIT(1),
};
@@ -245,7 +246,7 @@ static struct ti_ssp_data ssp_config = {
},
};
-static struct tnetv107x_device_info evm_device_info __initconst = {
+static struct tnetv107x_device_info evm_device_info __initdata = {
.serial_config = &serial_config,
.mmc_config[1] = &mmc_config, /* controller 1 */
.nand_config[0] = &nand_config, /* chip select 0 */
--
1.7.9.5
includes linux/io.h for fixing following build error. This build error
comes only after removing select option of NEED_MACH_GPIO_H for
ARCH_DAVINCI. linux/io.h is got included from mach/gpio-davinci.h on
selection of NEED_MACH_GPIO_H.
drivers/gpio/gpio-tnetv107x.c: In function 'tnetv107x_gpio_request':
drivers/gpio/gpio-tnetv107x.c:63:2: error: implicit declaration of
function '__raw_writel'
drivers/gpio/gpio-tnetv107x.c:63:2: error: implicit declaration of
function '__raw_readl'
drivers/gpio/gpio-tnetv107x.c: In function 'tnetv107x_gpio_setup':
drivers/gpio/gpio-tnetv107x.c:172:2: error: implicit declaration of
function 'ioremap'
drivers/gpio/gpio-tnetv107x.c:172:7: warning: assignment makes pointer
from integer without a cast
Signed-off-by: Philip Avinash <[email protected]>
---
drivers/gpio/gpio-tnetv107x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-tnetv107x.c b/drivers/gpio/gpio-tnetv107x.c
index 3fa3e28..c7ed335 100644
--- a/drivers/gpio/gpio-tnetv107x.c
+++ b/drivers/gpio/gpio-tnetv107x.c
@@ -14,6 +14,7 @@
*/
#include <linux/kernel.h>
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/gpio.h>
#include <mach/common.h>
--
1.7.9.5
On Fri, Jun 14, 2013 at 11:57 AM, Philip Avinash
<[email protected]> wrote:
> tnetv107x_defconfig build failing on removal selection of NEED_MACH_GPIO_H
> for ARCH_DAVINCI. This is due to header files inclusion from mach/gpio-davinci.h
> So this patch series fixes the build breakage on removal of NEED_MACH_GPIO_H.
>
> This patch series is based on Linux 3.10-rc4 and is availabel at [1] and dependency on 2.
>
> 1. https://github.com/avinashphilip/am335x_linux/tree/linux_davinci_v3.10_soc_gpio_v310-rc4
> 2. https://patchwork.kernel.org/patch/97853/
>
> Philip Avinash (2):
> ARM: davinci: fix for build breakage for tnetv107x platforms
> gpio: gpio-tnetv107x: Fix bulid breakge
The series:
Acked-by: Linus Walleij <[email protected]>
Yours,
Linus Walleij
On 6/14/2013 3:27 PM, Philip Avinash wrote:
> tnetv107x_defconfig build failing on removal selection of NEED_MACH_GPIO_H
> for ARCH_DAVINCI. This is due to header files inclusion from mach/gpio-davinci.h
> So this patch series fixes the build breakage on removal of NEED_MACH_GPIO_H.
So does this mean at the end of 7/7 of your "Convert GPIO Davinci to
platform driver" series, the build is broken?
If yes, then please include them when you repost that series before 7/7.
Having a patch break build is bad.
Thanks,
Sekhar
On 6/14/2013 3:27 PM, Philip Avinash wrote:
> Fix the following build breakage and section mismatch error. This build
> break will comes only on removal of NEED_MACH_GPIO_H select option for
> ARCH-DAVINCI.
>
> arch/arm/mach-davinci/board-tnetv107x-evm.c:283:15: error:
> 'davinci_timer_init' undeclared here (not in a function)
> arch/arm/mach-davinci/board-tnetv107x-evm.c:285:15: error:
> 'davinci_init_late' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-davinci/board-tnetv107x-evm.o] Error 1
Can you note the section mismatch error you saw too?
Thanks,
Sekhar