2013-06-17 10:08:23

by Fabio Baltieri

[permalink] [raw]
Subject: [PATCH] spi: pl022: remove unused ret and pins_state variables

Removes the warnings:

drivers/spi/spi-pl022.c: In function 'pl022_suspend_resources':
drivers/spi/spi-pl022.c:2322:24: warning: unused variable 'pins_state' [-Wunused-variable]
drivers/spi/spi-pl022.c:2321:6: warning: unused variable 'ret' [-Wunused-variable]
drivers/spi/spi-pl022.c: In function 'pl022_resume_resources':
drivers/spi/spi-pl022.c:2334:6: warning: unused variable 'ret' [-Wunused-variable]

introduced in:

f1c9cf0 spi: pl022: use pinctrl PM helpers

Signed-off-by: Fabio Baltieri <[email protected]>
---

Hi Linus,

this is just a quick build warning fixup patch found while playing with
today's linux-next, should apply cleanly on pinctrl/for-next.

Thanks,
Fabio

drivers/spi/spi-pl022.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 9652189..abef061 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2318,9 +2318,6 @@ pl022_remove(struct amba_device *adev)
*/
static void pl022_suspend_resources(struct pl022 *pl022, bool runtime)
{
- int ret;
- struct pinctrl_state *pins_state;
-
clk_disable(pl022->clk);

if (runtime)
@@ -2331,8 +2328,6 @@ static void pl022_suspend_resources(struct pl022 *pl022, bool runtime)

static void pl022_resume_resources(struct pl022 *pl022, bool runtime)
{
- int ret;
-
/* First go to the default state */
pinctrl_pm_select_default_state(&pl022->adev->dev);
if (!runtime)
--
1.8.2


2013-06-17 10:36:23

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: pl022: remove unused ret and pins_state variables

On Mon, Jun 17, 2013 at 12:08:15PM +0200, Fabio Baltieri wrote:
> Removes the warnings:
>
> drivers/spi/spi-pl022.c: In function 'pl022_suspend_resources':
> drivers/spi/spi-pl022.c:2322:24: warning: unused variable 'pins_state' [-Wunused-variable]
> drivers/spi/spi-pl022.c:2321:6: warning: unused variable 'ret' [-Wunused-variable]
> drivers/spi/spi-pl022.c: In function 'pl022_resume_resources':
> drivers/spi/spi-pl022.c:2334:6: warning: unused variable 'ret' [-Wunused-variable]
>
> introduced in:
>
> f1c9cf0 spi: pl022: use pinctrl PM helpers

Acked-by: Mark Brown <[email protected]>

Attachments:
(No filename) (596.00 B)
 signature.asc (836.00 B)
Digital signature Download all attachments

2013-06-17 11:22:32

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] spi: pl022: remove unused ret and pins_state variables

On Mon, Jun 17, 2013 at 12:08 PM, Fabio Baltieri
<[email protected]> wrote:

> Removes the warnings:
>
> drivers/spi/spi-pl022.c: In function 'pl022_suspend_resources':
> drivers/spi/spi-pl022.c:2322:24: warning: unused variable 'pins_state' [-Wunused-variable]
> drivers/spi/spi-pl022.c:2321:6: warning: unused variable 'ret' [-Wunused-variable]
> drivers/spi/spi-pl022.c: In function 'pl022_resume_resources':
> drivers/spi/spi-pl022.c:2334:6: warning: unused variable 'ret' [-Wunused-variable]
>
> introduced in:
>
> f1c9cf0 spi: pl022: use pinctrl PM helpers
>
> Signed-off-by: Fabio Baltieri <[email protected]>

How sloppy of me. Applied with Mark's ACK.

Thanks!
Linus Walleij