2013-06-27 12:26:25

by Vincent Stehlé

Subject: [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation

Fix following compilation error due to missing include file:

arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ‘enum reboot_mode’ declared inside parameter list [enabled by default]
arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (‘mode’) has incomplete type
arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1

Signed-off-by: Vincent Stehlé <[email protected]>
Cc: Robin Holt <[email protected]>
Cc: Russell King <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: [email protected]
---


Hi,

This fixes the build of linux-next for arch ARM, config multi_v7_defconfig, tag
next-20130627.

Best regards,

V.


arch/arm/mach-omap2/omap4-restart.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
index 652adde..41dfd7d 100644
--- a/arch/arm/mach-omap2/omap4-restart.c
+++ b/arch/arm/mach-omap2/omap4-restart.c
@@ -8,6 +8,7 @@
*/

#include <linux/types.h>
+#include <linux/reboot.h>
#include "prminst44xx.h"

/**
--
1.7.10.4

2013-06-27 13:18:49

by Nishanth Menon

Subject: Re: [PATCH linux-next] ARM: OMAP2+: fix omap4-restart compilation

On 06/27/2013 07:26 AM, Vincent Stehlé wrote:
> Fix following compilation error due to missing include file:
>
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ‘enum reboot_mode’ declared inside parameter list [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (‘mode’) has incomplete type
> arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
>
> Signed-off-by: Vincent Stehlé <[email protected]>
> Cc: Robin Holt <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: [email protected]
> ---
>
>
> Hi,
>
> This fixes the build of linux-next for arch ARM, config multi_v7_defconfig, tag
> next-20130627.
>
> Best regards,
>
> V.
>
>
> arch/arm/mach-omap2/omap4-restart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
> index 652adde..41dfd7d 100644
> --- a/arch/arm/mach-omap2/omap4-restart.c
> +++ b/arch/arm/mach-omap2/omap4-restart.c
> @@ -8,6 +8,7 @@
> */
>
> #include <linux/types.h>
> +#include <linux/reboot.h>
> #include "prminst44xx.h"
>
> /**
>
Same was covered already?
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html

--
Regards,
Nishanth Menon