2013-06-27 12:43:13

by Vincent Stehlé

[permalink] [raw]
Subject: [PATCH linux-next] arm: zynq: fix compilation warning

Fix the following compilation warning:

arch/arm/mach-zynq/common.c:110:2: warning: initialization from incompatible pointer type [enabled by default]
arch/arm/mach-zynq/common.c:110:2: warning: (near initialization for ‘__mach_desc_XILINX_EP107.restart’) [enabled by default]

Signed-off-by: Vincent Stehlé <[email protected]>
Cc: Robin Holt <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
---


Hi,

This warning was seen on linux-next tag next-20130627, with config ARM
multi_v7_defconfig.

Best regards,

V.


arch/arm/mach-zynq/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
index 4130e65..8ea5f11 100644
--- a/arch/arm/mach-zynq/common.c
+++ b/arch/arm/mach-zynq/common.c
@@ -91,7 +91,7 @@ static void __init zynq_map_io(void)
zynq_scu_map_io();
}

-static void zynq_system_reset(char mode, const char *cmd)
+static void zynq_system_reset(enum reboot_mode mode, const char *cmd)
{
zynq_slcr_system_reset();
}
--
1.7.10.4



2013-06-27 13:02:04

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH linux-next] arm: zynq: fix compilation warning

Hi Vincent,

Arnd asked in this post
http://www.mail-archive.com/[email protected]/msg454947.html
to fold his small patch to that larger one.

Not sure why it is not there.
Arnd, Robin?

Thanks
Michal


On 06/27/2013 02:42 PM, Vincent Stehlé wrote:
> Fix the following compilation warning:
>
> arch/arm/mach-zynq/common.c:110:2: warning: initialization from incompatible pointer type [enabled by default]
> arch/arm/mach-zynq/common.c:110:2: warning: (near initialization for ‘__mach_desc_XILINX_EP107.restart’) [enabled by default]
>
> Signed-off-by: Vincent Stehlé <[email protected]>
> Cc: Robin Holt <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: [email protected]
> ---
>
>
> Hi,
>
> This warning was seen on linux-next tag next-20130627, with config ARM
> multi_v7_defconfig.
>
> Best regards,
>
> V.
>
>
> arch/arm/mach-zynq/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
> index 4130e65..8ea5f11 100644
> --- a/arch/arm/mach-zynq/common.c
> +++ b/arch/arm/mach-zynq/common.c
> @@ -91,7 +91,7 @@ static void __init zynq_map_io(void)
> zynq_scu_map_io();
> }
>
> -static void zynq_system_reset(char mode, const char *cmd)
> +static void zynq_system_reset(enum reboot_mode mode, const char *cmd)
> {
> zynq_slcr_system_reset();
> }
>


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature

2013-06-28 00:39:00

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH linux-next] arm: zynq: fix compilation warning

On Thu, 27 Jun 2013 15:01:51 +0200 Michal Simek <[email protected]> wrote:
>
> Arnd asked in this post
> http://www.mail-archive.com/[email protected]/msg454947.html
> to fold his small patch to that larger one.
>
> Not sure why it is not there.
> Arnd, Robin?

Should have asked Andrew :-)

I have added (most of) Arnd's patch to the end of the akpm tree today.

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (444.00 B)
(No filename) (836.00 B)
Download all attachments

2013-07-23 18:09:10

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH linux-next] arm: zynq: fix compilation warning

On Thu, Jun 27, 2013 at 5:38 PM, Stephen Rothwell <[email protected]> wrote:
> On Thu, 27 Jun 2013 15:01:51 +0200 Michal Simek <[email protected]> wrote:
>>
>> Arnd asked in this post
>> http://www.mail-archive.com/[email protected]/msg454947.html
>> to fold his small patch to that larger one.
>>
>> Not sure why it is not there.
>> Arnd, Robin?
>
> Should have asked Andrew :-)
>
> I have added (most of) Arnd's patch to the end of the akpm tree today.

It was a dependency thing where new code was added in arm-soc, so the
sweeping patches in Andrew's tree couldn't cover them (without adding
said dependency and thus no longer apply on top of mainline).

I'll apply this and the keystone fix to the arm-soc fixes branch now
for 3.11-rc3.


-Olof