2013-07-02 12:16:00

by Oskar Andero

[permalink] [raw]

Subject: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

---

From: Shingo Nakao <[email protected]>

When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.

Signed-off-by: Shingo Nakao <[email protected]>
Cc: Milo Kim <[email protected]>
Cc: Richard Purdie <[email protected]>
Signed-off-by: Oskar Andero <[email protected]>
---
drivers/video/backlight/lp855x_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index a0e1e02..c0b41f1 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
{
struct lp855x *lp = bl_get_data(bl);

- if (bl->props.state & BL_CORE_SUSPENDED)
+ if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
bl->props.brightness = 0;

if (lp->mode == PWM_BASED) {
--
1.8.1.5

2013-07-02 23:25:03

by Kim, Milo

[permalink] [raw]

Subject: Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

---

> From: Shingo Nakao <[email protected]>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <[email protected]>
> Cc: Milo Kim <[email protected]>
> Cc: Richard Purdie <[email protected]>
> Signed-off-by: Oskar Andero <[email protected]>

Acked-by: Milo Kim <[email protected]>

> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
> --
> 1.8.1.5

2013-07-03 01:52:21

by Jingoo Han

[permalink] [raw]

Subject: Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

---

On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote:
>
> From: Shingo Nakao <[email protected]>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <[email protected]>
> Cc: Milo Kim <[email protected]>
> Cc: Richard Purdie <[email protected]>
> Signed-off-by: Oskar Andero <[email protected]>

Acked-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
> --
> 1.8.1.5
>

2013-07-26 08:46:00

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK

---

On 02/07/13 15:15, Oskar Andero wrote:
> From: Shingo Nakao <[email protected]>
>
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
>
> Signed-off-by: Shingo Nakao <[email protected]>
> Cc: Milo Kim <[email protected]>
> Cc: Richard Purdie <[email protected]>
> Signed-off-by: Oskar Andero <[email protected]>
> ---
> drivers/video/backlight/lp855x_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
> {
> struct lp855x *lp = bl_get_data(bl);
>
> - if (bl->props.state & BL_CORE_SUSPENDED)
> + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
> bl->props.brightness = 0;
>
> if (lp->mode == PWM_BASED) {
>

Thanks, I've applied this into my 3.12/fbdev branch.

Tomi

---

Attachments:

signature.asc (901.00 B)
OpenPGP digital signature