2013-07-03 14:42:44

by Nicolas Palix (LIG)

Subject: [PATCH] Coccinelle: Update information about the minimal version required

The naming convention of options has changed one year ago.
The options have been recently updated in the cocci file
and in scripts/coccicheck. This patch also adds this information
in the documentation.

Signed-off-by: Nicolas Palix <[email protected]>
---
Documentation/coccinelle.txt | 19 ++++++++-----------
scripts/coccicheck | 5 +++++
2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
index 81a329f..7f773d5 100644
--- a/Documentation/coccinelle.txt
+++ b/Documentation/coccinelle.txt
@@ -6,15 +6,17 @@ Copyright 2010 Gilles Muller <[email protected]>
Getting Coccinelle
~~~~~~~~~~~~~~~~~~~~

-The semantic patches included in the kernel use the 'virtual rule'
-feature which was introduced in Coccinelle version 0.1.11.
+The semantic patches included in the kernel use features and options
+which are provided by Coccinelle version 1.0.0-rc11 and above.
+Using earlier versions will fail as the option names used by
+the Coccinelle files and coccicheck have been updated.

-Coccinelle (>=0.2.0) is available through the package manager
+Coccinelle is available through the package manager
of many distributions, e.g. :

- - Debian (>=squeeze)
- - Fedora (>=13)
- - Ubuntu (>=10.04 Lucid Lynx)
+ - Debian
+ - Fedora
+ - Ubuntu
- OpenSUSE
- Arch Linux
- NetBSD
@@ -36,11 +38,6 @@ as a regular user, and install it with

sudo make install

-The semantic patches in the kernel will work best with Coccinelle version
-0.2.4 or later. Using earlier versions may incur some parse errors in the
-semantic patch code, but any results that are obtained should still be
-correct.
-
Using Coccinelle on the Linux kernel
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

diff --git a/scripts/coccicheck b/scripts/coccicheck
index d3757ad..bbf901a 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -1,5 +1,10 @@
#!/bin/bash

+#
+# This script requires at least spatch
+# version 1.0.0-rc11.
+#
+
SPATCH="`which ${SPATCH:=spatch}`"

trap kill_running SIGTERM SIGINT
--
1.7.9.5

2013-07-03 21:00:10

by Michal Marek

Subject: Re: [PATCH] Coccinelle: Update information about the minimal version required

Dne 3.7.2013 16:41, Nicolas Palix napsal(a):
> The naming convention of options has changed one year ago.
> The options have been recently updated in the cocci file
> and in scripts/coccicheck. This patch also adds this information
> in the documentation.
>
> Signed-off-by: Nicolas Palix <[email protected]>

I applied this and the patch that changes the options to kbuild.git#misc.

Thanks,
Michal