2013-07-09 07:36:12

by Srinivas KANDAGATLA

[permalink] [raw]
Subject: [PATCH v2 0/2] ARM: STi Fixes

From: Srinivas Kandagatla <[email protected]>

This patch series fixes 2 configuration issues related to serial
setup on STiH416 and ARM ERRATA selection.

Changes since v1:
- Split out fixes in seperate patch set.

Srinivas Kandagatla (2):
ARM: dts: STi: Fix pinconf setup for STiH416 serial2
ARM: STi: Set correct ARM ERRATAs.

arch/arm/boot/dts/stih416-pinctrl.dtsi | 10 +++++++++-
arch/arm/boot/dts/stih416.dtsi | 2 +-
arch/arm/mach-sti/Kconfig | 3 ++-
3 files changed, 12 insertions(+), 3 deletions(-)

--
1.7.6.5


2013-07-09 07:34:12

by Srinivas KANDAGATLA

[permalink] [raw]
Subject: [PATCH v2 2/2] ARM: STi: Set correct ARM ERRATAs.

From: Srinivas Kandagatla <[email protected]>

Some of the ARM_ERRATA selection is not done in the initial SOC support
patches. This patch selects 2 new ARM_ERRATA's and removes one which was
actually fixed.

Signed-off-by: Srinivas Kandagatla <[email protected]>
---
arch/arm/mach-sti/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
index d04e3bf..c216094 100644
--- a/arch/arm/mach-sti/Kconfig
+++ b/arch/arm/mach-sti/Kconfig
@@ -11,8 +11,9 @@ menuconfig ARCH_STI
select HAVE_SMP
select HAVE_ARM_SCU if SMP
select ARCH_REQUIRE_GPIOLIB
- select ARM_ERRATA_720789
select ARM_ERRATA_754322
+ select ARM_ERRATA_775420
+ select ARM_ERRATA_764369
select PL310_ERRATA_753970 if CACHE_PL310
select PL310_ERRATA_769419 if CACHE_PL310
help
--
1.7.6.5

2013-07-09 08:06:43

by Srinivas KANDAGATLA

[permalink] [raw]
Subject: [PATCH v2 1/2] ARM: dts: STi: Fix pinconf setup for STiH416 serial2

From: Srinivas Kandagatla <[email protected]>

This patch fixes a bug in pinctrl setup of serial2 device, Some of the
pins in the pinctrl node of serial2 do not belong to that
pin-controller. This patch divides them in the pins into there
respective pin controller nodes.

Without this patch serial on StiH416-B2000 Board will not work as it
fails with:

"st-pinctrl pin-controller-rear.3: failed to get pin(99) name
st-pinctrl pin-controller-rear.3: maps: function serial2 group serial2-0
num 4
pinconfig core: failed to register map default (3): no group/pin given"

Signed-off-by: Srinivas Kandagatla <[email protected]>
---
arch/arm/boot/dts/stih416-pinctrl.dtsi | 10 +++++++++-
arch/arm/boot/dts/stih416.dtsi | 2 +-
2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stih416-pinctrl.dtsi b/arch/arm/boot/dts/stih416-pinctrl.dtsi
index 957b21a..0f246c9 100644
--- a/arch/arm/boot/dts/stih416-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih416-pinctrl.dtsi
@@ -166,6 +166,15 @@
reg = <0x9000 0x100>;
st,bank-name = "PIO31";
};
+
+ serial2-oe {
+ pinctrl_serial2_oe: serial2-1 {
+ st,pins {
+ output-enable = <&PIO11 3 ALT2 OUT>;
+ };
+ };
+ };
+
};

pin-controller-rear {
@@ -218,7 +227,6 @@
st,pins {
tx = <&PIO17 4 ALT2 OUT>;
rx = <&PIO17 5 ALT2 IN>;
- output-enable = <&PIO11 3 ALT2 OUT>;
};
};
};
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 3cecd96..1a0326e 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -79,7 +79,7 @@
interrupts = <0 197 0>;
clocks = <&CLK_S_ICN_REG_0>;
pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_serial2>;
+ pinctrl-0 = <&pinctrl_serial2 &pinctrl_serial2_oe>;
};

/* SBC_UART1 */
--
1.7.6.5

2013-07-23 02:35:39

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] ARM: STi: Set correct ARM ERRATAs.

On Tue, Jul 09, 2013 at 08:26:33AM +0100, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <[email protected]>
>
> Some of the ARM_ERRATA selection is not done in the initial SOC support
> patches. This patch selects 2 new ARM_ERRATA's and removes one which was
> actually fixed.

These entries should be sorted, and you inserted in random order.

I'll rearrange the order when applying.

(Patch applied with that change).

Thanks,

-Olof

2013-07-23 02:35:51

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] ARM: dts: STi: Fix pinconf setup for STiH416 serial2

On Tue, Jul 09, 2013 at 08:26:24AM +0100, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <[email protected]>
>
> This patch fixes a bug in pinctrl setup of serial2 device, Some of the
> pins in the pinctrl node of serial2 do not belong to that
> pin-controller. This patch divides them in the pins into there
> respective pin controller nodes.
>
> Without this patch serial on StiH416-B2000 Board will not work as it
> fails with:
>
> "st-pinctrl pin-controller-rear.3: failed to get pin(99) name
> st-pinctrl pin-controller-rear.3: maps: function serial2 group serial2-0
> num 4
> pinconfig core: failed to register map default (3): no group/pin given"
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>

Applied to fixes, thanks.


-Olof

2013-07-23 07:34:39

by Srinivas KANDAGATLA

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] ARM: STi: Set correct ARM ERRATAs.


On 23/07/13 03:35, Olof Johansson wrote:
> On Tue, Jul 09, 2013 at 08:26:33AM +0100, Srinivas KANDAGATLA wrote:
>> From: Srinivas Kandagatla <[email protected]>
>>
>> Some of the ARM_ERRATA selection is not done in the initial SOC support
>> patches. This patch selects 2 new ARM_ERRATA's and removes one which was
>> actually fixed.
>
> These entries should be sorted, and you inserted in random order.
Thanks Olof.
I will take a note of it.

>
> I'll rearrange the order when applying.
>
> (Patch applied with that change).
>
> Thanks,
>
> -Olof
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>