2013-07-09 08:36:34

by Jongsung Kim

Subject: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit

Signed-off-by: Jongsung Kim <[email protected]>
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
static void macb_configure_caps(struct macb *bp)
{
if (macb_is_gem(bp)) {
- if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
+ if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
}
}
--
1.7.1

2013-07-09 16:02:25

by Nicolas Ferre

Subject: Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit

On 09/07/2013 10:36, Jongsung Kim :
> Signed-off-by: Jongsung Kim <[email protected]>

Acked-by: Nicolas Ferre <[email protected]>
Cc: stable <[email protected]> # 3.10+

Thanks for having spotted that.

Best regards,

> ---
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index c89aa41..b4e0dc8 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1070,7 +1070,7 @@ static void macb_configure_dma(struct macb *bp)
> static void macb_configure_caps(struct macb *bp)
> {
> if (macb_is_gem(bp)) {
> - if (GEM_BF(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> + if (GEM_BFEXT(IRQCOR, gem_readl(bp, DCFG1)) == 0)
> bp->caps |= MACB_CAPS_ISR_CLEAR_ON_WRITE;
> }
> }
>


--
Nicolas Ferre

2013-07-09 19:50:45

by David Miller

Subject: Re: [PATCH] net/cadence/macb: fix bug/typo in extracting gem_irq_read_clear bit

From: Nicolas Ferre <[email protected]>
Date: Tue, 9 Jul 2013 18:02:23 +0200

> On 09/07/2013 10:36, Jongsung Kim :
>> Signed-off-by: Jongsung Kim <[email protected]>
>
> Acked-by: Nicolas Ferre <[email protected]>
> Cc: stable <[email protected]> # 3.10+

Applied and queued up for -stable, thanks.