2013-07-12 14:00:50

by Alexandru Juncu

[permalink] [raw]

Subject: [PATCH] matroxfb: replace kmalloc and memset with kzalloc.

---

Signed-off-by: Alexandru Juncu <[email protected]>
---
drivers/video/matrox/matroxfb_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_base.c b/drivers/video/matrox/matroxfb_base.c
index 401a56e..2456529 100644
--- a/drivers/video/matrox/matroxfb_base.c
+++ b/drivers/video/matrox/matroxfb_base.c
@@ -2029,10 +2029,9 @@ static int matroxfb_probe(struct pci_dev* pdev, const struct pci_device_id* dumm
return -1;
}

- minfo = kmalloc(sizeof(*minfo), GFP_KERNEL);
+ minfo = kzalloc(sizeof(*minfo), GFP_KERNEL);
if (!minfo)
return -1;
- memset(minfo, 0, sizeof(*minfo));

minfo->pcidev = pdev;
minfo->dead = 0;
--
1.8.1.2

2013-07-26 08:36:53

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] matroxfb: replace kmalloc and memset with kzalloc.

---

On 12/07/13 17:00, Alexandru Juncu wrote:
> Signed-off-by: Alexandru Juncu <[email protected]>
> ---
> drivers/video/matrox/matroxfb_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/matrox/matroxfb_base.c b/drivers/video/matrox/matroxfb_base.c
> index 401a56e..2456529 100644
> --- a/drivers/video/matrox/matroxfb_base.c
> +++ b/drivers/video/matrox/matroxfb_base.c
> @@ -2029,10 +2029,9 @@ static int matroxfb_probe(struct pci_dev* pdev, const struct pci_device_id* dumm
> return -1;
> }
>
> - minfo = kmalloc(sizeof(*minfo), GFP_KERNEL);
> + minfo = kzalloc(sizeof(*minfo), GFP_KERNEL);
> if (!minfo)
> return -1;
> - memset(minfo, 0, sizeof(*minfo));
>
> minfo->pcidev = pdev;
> minfo->dead = 0;
>

Thanks, I've applied this into my 3.12/fbdev branch.

Tomi

---

Attachments:

signature.asc (901.00 B)
OpenPGP digital signature