2013-07-15 06:30:05

by Yijing Wang

[permalink] [raw]
Subject: [PATCH] video: remove unused variable "dev" in vga16fb_destroy()

Delete unused variable "dev" to fix build warning in
drivers/video/vga16fb.c

Signed-off-by: Yijing Wang <[email protected]>
Cc: Jingoo Han <[email protected]>
---
drivers/video/vga16fb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image

static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.7.1


2013-07-15 07:14:01

by Jingoo Han

[permalink] [raw]
Subject: Re: [PATCH] video: remove unused variable "dev" in vga16fb_destroy()

On Monday, July 15, 2013 3:29 PM, Yijing Wang wrote:
>
> Delete unused variable "dev" to fix build warning in
> drivers/video/vga16fb.c
>
> Signed-off-by: Yijing Wang <[email protected]>
> Cc: Jingoo Han <[email protected]>

It looks good.
Reviewed-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/video/vga16fb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>
> static void vga16fb_destroy(struct fb_info *info)
> {
> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
> iounmap(info->screen_base);
> fb_dealloc_cmap(&info->cmap);
> /* XXX unshare VGA regions */
> --
> 1.7.1