2013-07-19 13:10:27

by Julien Grall

Subject: [PATCH v2] xen/arm: enable PV control for ARM

Enable power management from the toolstack for ARM guest.

Signed-off-by: Julien Grall <[email protected]>

---
Changes in v2:
- Don't compile xen/cpu_hotplug.o with ARM64
---
drivers/xen/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 2bf461a..b550a94 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -1,9 +1,8 @@
-ifneq ($(CONFIG_ARM),y)
-obj-y += manage.o
+ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),)
obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
endif
obj-$(CONFIG_X86) += fallback.o
-obj-y += grant-table.o features.o events.o balloon.o time.o
+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
obj-y += xenbus/

nostackp := $(call cc-option, -fno-stack-protector)
--
1.7.10.4

2013-07-21 14:54:28

by Stefano Stabellini

Subject: Re: [PATCH v2] xen/arm: enable PV control for ARM

On Fri, 19 Jul 2013, Julien Grall wrote:
> Enable power management from the toolstack for ARM guest.
>
> Signed-off-by: Julien Grall <[email protected]>
>
> ---
> Changes in v2:
> - Don't compile xen/cpu_hotplug.o with ARM64
> ---
> drivers/xen/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 2bf461a..b550a94 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -1,9 +1,8 @@
> -ifneq ($(CONFIG_ARM),y)
> -obj-y += manage.o
> +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y

This is wrong: ifneq is checking for the opposite condition of what we want, and
beside you have the $ in the wrong place for CONFIG_ARM.

Please test you patches before sending them.


> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> endif
> obj-$(CONFIG_X86) += fallback.o
> -obj-y += grant-table.o features.o events.o balloon.o time.o
> +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
> obj-y += xenbus/
>
> nostackp := $(call cc-option, -fno-stack-protector)
> --
> 1.7.10.4
>

2013-07-21 20:59:54

by Julien Grall

Subject: Re: [PATCH v2] xen/arm: enable PV control for ARM

On 21 July 2013 15:54, Stefano Stabellini
<[email protected]> wrote:
> On Fri, 19 Jul 2013, Julien Grall wrote:
>> Enable power management from the toolstack for ARM guest.
>>
>> Signed-off-by: Julien Grall <[email protected]>
>>
>> ---
>> Changes in v2:
>> - Don't compile xen/cpu_hotplug.o with ARM64
>> ---
>> drivers/xen/Makefile | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index 2bf461a..b550a94 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -1,9 +1,8 @@
>> -ifneq ($(CONFIG_ARM),y)
>> -obj-y += manage.o
>> +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y
>
> This is wrong: ifneq is checking for the opposite condition of what we want, and
> beside you have the $ in the wrong place for CONFIG_ARM.
>
> Please test you patches before sending them.

My apologies, I tried without any issue on ARM (certainly, because of
the $ in wrong place).

I will send a new patch.

--
Julien Grall