2013-07-22 16:44:05

by Peng Tao

Subject: [PATCH] staging/lustre: fix Kconfig bool defaults

Should be y/n instead of true/false...

Reported-by: Paul Bolle <[email protected]>
Cc: Andreas Dilger <[email protected]>
Signed-off-by: Peng Tao <[email protected]>
---
This applis on top of the 48 Intel tree ported patches.

drivers/staging/lustre/lustre/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index 566d89d..d80a78f 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -50,7 +50,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
config LUSTRE_DEBUG_LU_REF_CHECK
bool "Enable Lustre DEBUG object refcount checks"
depends on LUSTRE_FS
- default false
+ default n
help
This option is mainly for debug purpose. It enables Lustre code to track
references between objects.
@@ -60,7 +60,7 @@ config LUSTRE_DEBUG_LU_REF_CHECK
config LUSTRE_DEBUG_EXPENSIVE_CHECK
bool "Enable Lustre DEBUG checks"
depends on LUSTRE_FS
- default false
+ default n
help
This option is mainly for debug purpose. It enables Lustre code to do
expensive checks that may have a performance impact.
@@ -70,4 +70,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
config LUSTRE_TRANSLATE_ERRNOS
bool
depends on LUSTRE_FS && !X86
- default true
+ default y
--
1.7.9.5

2013-07-22 17:33:37

by Sam Ravnborg

Subject: Re: [PATCH] staging/lustre: fix Kconfig bool defaults

On Tue, Jul 23, 2013 at 12:41:30AM +0800, Peng Tao wrote:
> Should be y/n instead of true/false...
>
> Reported-by: Paul Bolle <[email protected]>
> Cc: Andreas Dilger <[email protected]>
> Signed-off-by: Peng Tao <[email protected]>

default n is the default.
So usually we advice to drop this.

Sam


> ---
> This applis on top of the 48 Intel tree ported patches.
>
> drivers/staging/lustre/lustre/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 566d89d..d80a78f 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -50,7 +50,7 @@ config LUSTRE_OBD_MAX_IOCTL_BUFFER
> config LUSTRE_DEBUG_LU_REF_CHECK
> bool "Enable Lustre DEBUG object refcount checks"
> depends on LUSTRE_FS
> - default false
> + default n
> help
> This option is mainly for debug purpose. It enables Lustre code to track
> references between objects.
> @@ -60,7 +60,7 @@ config LUSTRE_DEBUG_LU_REF_CHECK
> config LUSTRE_DEBUG_EXPENSIVE_CHECK
> bool "Enable Lustre DEBUG checks"
> depends on LUSTRE_FS
> - default false
> + default n
> help
> This option is mainly for debug purpose. It enables Lustre code to do
> expensive checks that may have a performance impact.
> @@ -70,4 +70,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
> config LUSTRE_TRANSLATE_ERRNOS
> bool
> depends on LUSTRE_FS && !X86
> - default true
> + default y
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2013-07-23 20:50:52

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging/lustre: fix Kconfig bool defaults

On Mon, Jul 22, 2013 at 07:33:33PM +0200, Sam Ravnborg wrote:
> On Tue, Jul 23, 2013 at 12:41:30AM +0800, Peng Tao wrote:
> > Should be y/n instead of true/false...
> >
> > Reported-by: Paul Bolle <[email protected]>
> > Cc: Andreas Dilger <[email protected]>
> > Signed-off-by: Peng Tao <[email protected]>
>
> default n is the default.
> So usually we advice to drop this.

I agree, just delete the lines, no need to be explicit with the default.

thanks,

greg k-h