2013-07-22 21:41:07

by Julien Grall

[permalink] [raw]
Subject: [PATCH] xen/arm64: Don't compile cpu hotplug

On ARM64, when CONFIG_XEN=y, the compilation will fail because CPU hotplug is
not yet supported with XEN. For now, disable it.

Signed-off-by: Julien Grall <[email protected]>
---
drivers/xen/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 2bf461a..a609353 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -1,4 +1,4 @@
-ifneq ($(CONFIG_ARM),y)
+ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
obj-y += manage.o
obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
endif
--
1.7.10.4


2013-07-23 09:35:51

by Mark Rutland

[permalink] [raw]
Subject: Re: [PATCH] xen/arm64: Don't compile cpu hotplug

On Mon, Jul 22, 2013 at 10:40:58PM +0100, Julien Grall wrote:
> On ARM64, when CONFIG_XEN=y, the compilation will fail because CPU hotplug is
> not yet supported with XEN. For now, disable it.
>
> Signed-off-by: Julien Grall <[email protected]>

With this applied I'm able to build an arm64 kernel with both
CONFIG_HOTPLUG_CPU (from local patches) and CONFIG_XEN.

Acked-by: Mark Rutland <[email protected]>

Cheers,
Mark.

> ---
> drivers/xen/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 2bf461a..a609353 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -1,4 +1,4 @@
> -ifneq ($(CONFIG_ARM),y)
> +ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> obj-y += manage.o
> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> endif
> --
> 1.7.10.4
>
>

2013-07-23 11:35:46

by Stefano Stabellini

[permalink] [raw]
Subject: Re: [PATCH] xen/arm64: Don't compile cpu hotplug

On Mon, 22 Jul 2013, Julien Grall wrote:
> On ARM64, when CONFIG_XEN=y, the compilation will fail because CPU hotplug is
> not yet supported with XEN. For now, disable it.
>
> Signed-off-by: Julien Grall <[email protected]>

Acked-by: Stefano Stabellini <[email protected]>


> drivers/xen/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 2bf461a..a609353 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -1,4 +1,4 @@
> -ifneq ($(CONFIG_ARM),y)
> +ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> obj-y += manage.o
> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> endif
> --
> 1.7.10.4
>