2013-07-23 23:10:53

by Andi Shyti

Subject: [PATCH] fs: bio-integrity: fix possible segmentation fault

free bvec_integrity_pool if it's allocated, not bio_integrity_pool

Signed-off-by: Andi Shyti <[email protected]>
---
fs/bio-integrity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
index 8fb4291..45e944f 100644
--- a/fs/bio-integrity.c
+++ b/fs/bio-integrity.c
@@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
mempool_destroy(bs->bio_integrity_pool);

if (bs->bvec_integrity_pool)
- mempool_destroy(bs->bio_integrity_pool);
+ mempool_destroy(bs->bvec_integrity_pool);
}
EXPORT_SYMBOL(bioset_integrity_free);

--
1.8.3.2

2013-07-24 01:05:44

by Gu Zheng

Subject: Re: [PATCH] fs: bio-integrity: fix possible segmentation fault

On 07/24/2013 07:12 AM, Andi Shyti wrote:

> free bvec_integrity_pool if it's allocated, not bio_integrity_pool
>
> Signed-off-by: Andi Shyti <[email protected]>


Reviewed-by: Gu Zheng <[email protected]>

> ---
> fs/bio-integrity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 8fb4291..45e944f 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
> mempool_destroy(bs->bio_integrity_pool);
>
> if (bs->bvec_integrity_pool)
> - mempool_destroy(bs->bio_integrity_pool);
> + mempool_destroy(bs->bvec_integrity_pool);
> }
> EXPORT_SYMBOL(bioset_integrity_free);
>