2013-07-25 00:33:15

by Andi Shyti

Subject: [PATCH] ext4: extents: len and lblock may be used uninitialized

if ext_debugging is enabled and path[depth].p_ext is NULL, len
and lblock are printed non initialized

Signed-off-by: Andi Shyti <[email protected]>
---
fs/ext4/extents.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index a618738..acaf53c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2195,8 +2195,8 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
ext4_lblk_t block)
{
int depth = ext_depth(inode);
- unsigned long len;
- ext4_lblk_t lblock;
+ unsigned long len = 0;
+ ext4_lblk_t lblock = 0;
struct ext4_extent *ex;

ex = path[depth].p_ext;
@@ -2233,7 +2233,6 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
ext4_es_insert_extent(inode, lblock, len, ~0,
EXTENT_STATUS_HOLE);
} else {
- lblock = len = 0;
BUG();
}

--
1.8.3.2

2013-08-28 18:21:04

by Theodore Ts'o

Subject: Re: [PATCH] ext4: extents: len and lblock may be used uninitialized

On Thu, Jul 25, 2013 at 02:33:05AM +0200, Andi Shyti wrote:
> if ext_debugging is enabled and path[depth].p_ext is NULL, len
> and lblock are printed non initialized
>
> Signed-off-by: Andi Shyti <[email protected]>

Thanks, applied.

- Ted