2013-07-31 14:31:04

by Lothar Waßmann

Subject: [PATCH 07/25] dma: of: make error message more meaningful by adding the node name

Signed-off-by: Lothar Waßmann <[email protected]>
---
drivers/dma/of-dma.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index 75334bd..0b88dd3 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -160,7 +160,8 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np,

count = of_property_count_strings(np, "dma-names");
if (count < 0) {
- pr_err("%s: dma-names property missing or empty\n", __func__);
+ pr_err("%s: dma-names property of node '%s' missing or empty\n",
+ __func__, np->full_name);
return NULL;
}

--
1.7.2.5

2013-08-19 09:58:44

by Vinod Koul

Subject: Re: [PATCH 07/25] dma: of: make error message more meaningful by adding the node name

On Wed, Jul 31, 2013 at 04:14:35PM +0200, Lothar Wa?mann wrote:
>
> Signed-off-by: Lothar Wa?mann <[email protected]>
Applied, thanks

~Vinod
> ---
> drivers/dma/of-dma.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
> index 75334bd..0b88dd3 100644
> --- a/drivers/dma/of-dma.c
> +++ b/drivers/dma/of-dma.c
> @@ -160,7 +160,8 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
>
> count = of_property_count_strings(np, "dma-names");
> if (count < 0) {
> - pr_err("%s: dma-names property missing or empty\n", __func__);
> + pr_err("%s: dma-names property of node '%s' missing or empty\n",
> + __func__, np->full_name);
> return NULL;
> }
>
> --
> 1.7.2.5
>

--