2013-07-30 15:17:47

by Richard Genoud

Subject: [PATCH resend] MTD: atmel_nand: using a stronger ECC is not dangerous

We don't have to issue a warning when a stronger error correting
capability is chosen.

Signed-off-by: Richard Genoud <[email protected]>
Acked-by: Josh Wu <[email protected]>
---
It seems that this patch has been forgotten (even by me)
for some months. (was already acked by Josh then)
Reference of the discussion leading to this patch:
http://comments.gmane.org/gmane.linux.drivers.mtd/46342

drivers/mtd/nand/atmel_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..2415cdc 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
return err_no;
}

- if (cap != host->pmecc_corr_cap ||
+ if (cap > host->pmecc_corr_cap ||
sector_size != host->pmecc_sector_size)
dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");

--
1.7.10.4

2013-08-02 14:46:35

by Artem Bityutskiy

Subject: Re: [PATCH resend] MTD: atmel_nand: using a stronger ECC is not dangerous

On Tue, 2013-07-30 at 17:17 +0200, Richard Genoud wrote:
> We don't have to issue a warning when a stronger error correting
> capability is chosen.
>
> Signed-off-by: Richard Genoud <[email protected]>
> Acked-by: Josh Wu <[email protected]>

Pushed to l2-mtd.git, thanks!

--
Best Regards,
Artem Bityutskiy