2013-08-05 18:18:59

by Dongjin Kim

Subject: [PATCH RESEND] ARM: dts: Add USBPHY nodes to Exynos4x12

This patch adds device nodes for USBPHY to Exynos4x12.

CC: Sachin Kamat <[email protected]>
Signed-off-by: Dongjin Kim <[email protected]>
---
arch/arm/boot/dts/exynos4x12.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 01da194..9c3335b 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -73,4 +73,22 @@
clock-names = "sclk_fimg2d", "fimg2d";
status = "disabled";
};
+
+ usbphy@125B00000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "samsung,exynos4x12-usb2phy";
+ reg = <0x125B0000 0x100>;
+ ranges;
+
+ clocks = <&clock 2>, <&clock 305>;
+ clock-names = "xusbxti", "otg";
+ status = "disabled";
+
+ usbphy-sys {
+ /* USB device and host PHY_CONTROL registers */
+ reg = <0x10020704 0xc>,
+ <0x1001021c 0x4>;
+ };
+ };
};
--
1.7.9.5

2013-08-06 06:09:59

by Sachin Kamat

Subject: Re: [PATCH RESEND] ARM: dts: Add USBPHY nodes to Exynos4x12

Hi Dongjin,

On 5 August 2013 23:48, Dongjin Kim <[email protected]> wrote:
> This patch adds device nodes for USBPHY to Exynos4x12.
>
> CC: Sachin Kamat <[email protected]>
> Signed-off-by: Dongjin Kim <[email protected]>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 01da194..9c3335b 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -73,4 +73,22 @@
> clock-names = "sclk_fimg2d", "fimg2d";
> status = "disabled";
> };
> +
> + usbphy@125B00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "samsung,exynos4x12-usb2phy";
> + reg = <0x125B0000 0x100>;
> + ranges;
> +
> + clocks = <&clock 2>, <&clock 305>;
> + clock-names = "xusbxti", "otg";
> + status = "disabled";

I don't think this node has any other board specific dependencies. In
that case you don't need to disable this.

> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers */
> + reg = <0x10020704 0xc>,
> + <0x1001021c 0x4>;
> + };
> + };
> };
> --
> 1.7.9.5
>



--
With warm regards,
Sachin

2013-08-06 16:48:10

by Dongjin Kim

Subject: Re: [PATCH RESEND] ARM: dts: Add USBPHY nodes to Exynos4x12

Aha, yes...my misunderstanding.
This node is not only for OTG or HSIC, could miss USB HOST transceiver
if certain board file does not set "okay".

Thanks,
Dongjin.

On Tue, Aug 6, 2013 at 3:09 PM, Sachin Kamat <[email protected]> wrote:
> Hi Dongjin,
>
> On 5 August 2013 23:48, Dongjin Kim <[email protected]> wrote:
>> This patch adds device nodes for USBPHY to Exynos4x12.
>>
>> CC: Sachin Kamat <[email protected]>
>> Signed-off-by: Dongjin Kim <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos4x12.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index 01da194..9c3335b 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -73,4 +73,22 @@
>> clock-names = "sclk_fimg2d", "fimg2d";
>> status = "disabled";
>> };
>> +
>> + usbphy@125B00000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "samsung,exynos4x12-usb2phy";
>> + reg = <0x125B0000 0x100>;
>> + ranges;
>> +
>> + clocks = <&clock 2>, <&clock 305>;
>> + clock-names = "xusbxti", "otg";
>> + status = "disabled";
>
> I don't think this node has any other board specific dependencies. In
> that case you don't need to disable this.
>
>> +
>> + usbphy-sys {
>> + /* USB device and host PHY_CONTROL registers */
>> + reg = <0x10020704 0xc>,
>> + <0x1001021c 0x4>;
>> + };
>> + };
>> };
>> --
>> 1.7.9.5
>>
>
>
>
> --
> With warm regards,
> Sachin