2013-08-07 08:36:26

by Naveen Krishna Chatradhi

Subject: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

The error check is checking for a "base" mapped memory base
instead of "base_common". Fixing the same.

Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
---
drivers/thermal/samsung/exynos_tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index ec01dfe..a033dbb 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)

data->base_common = devm_ioremap(&pdev->dev, res.start,
resource_size(&res));
- if (!data->base) {
+ if (!data->base_common) {
dev_err(&pdev->dev, "Failed to ioremap memory\n");
return -ENOMEM;
}
--
1.7.9.5

2013-08-15 07:01:09

by Zhang, Rui

Subject: Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote:
> The error check is checking for a "base" mapped memory base
> instead of "base_common". Fixing the same.
>
> Signed-off-by: Naveen Krishna Chatradhi <[email protected]>

applied. Thanks!
BTW, can you rebase the other three exynos patches you submitted?

thanks,
rui
> ---
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index ec01dfe..a033dbb 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
>
> data->base_common = devm_ioremap(&pdev->dev, res.start,
> resource_size(&res));
> - if (!data->base) {
> + if (!data->base_common) {
> dev_err(&pdev->dev, "Failed to ioremap memory\n");
> return -ENOMEM;
> }

2013-08-15 09:07:25

by Naveen Krishna Ch

Subject: Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

On 15 August 2013 12:32, Zhang Rui <[email protected]> wrote:
>
> On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote:
> > The error check is checking for a "base" mapped memory base
> > instead of "base_common". Fixing the same.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
>
> applied. Thanks!
> BTW, can you rebase the other three exynos patches you submitted?
I mistakenly rebased on the master branch.
Later found the code base is a lot different in the for-next branch.
I've it in my pipe line, Will submit at the soon.

Thanks Rui,

>
> thanks,
> rui
> > ---
> > drivers/thermal/samsung/exynos_tmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> > index ec01dfe..a033dbb 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
> >
> > data->base_common = devm_ioremap(&pdev->dev, res.start,
> > resource_size(&res));
> > - if (!data->base) {
> > + if (!data->base_common) {
> > dev_err(&pdev->dev, "Failed to ioremap memory\n");
> > return -ENOMEM;
> > }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/




--
Shine bright,
(: Nav :)