2013-08-14 23:05:08

by Kevin Hilman

[permalink] [raw]
Subject: [PATCH] regmap: Add another missing header for !CONFIG_REGMAP stubs

The use of WARN_ON() needs the definitions from bug.h, without it
you can get:

include/linux/regmap.h: In function 'regmap_write':
include/linux/regmap.h:525:2: error: implicit declaration of function 'WARN_ONCE' [-Werror=implicit-function-declaration]

Cc: Mark Brown <[email protected]>
Signed-off-by: Kevin Hilman <[email protected]>
---
This one has been showing up in linux-next for a bit under various ARM
defconfigs (specifically ape6evm_defconfig and lager_defconfig)u

include/linux/regmap.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index bafda87..a10380b 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -16,6 +16,7 @@
#include <linux/list.h>
#include <linux/rbtree.h>
#include <linux/err.h>
+#include <linux/bug.h>

struct module;
struct device;
--
1.8.3


2013-08-15 11:09:50

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regmap: Add another missing header for !CONFIG_REGMAP stubs

On Wed, Aug 14, 2013 at 04:05:02PM -0700, Kevin Hilman wrote:
> The use of WARN_ON() needs the definitions from bug.h, without it
> you can get:

Applied, thanks.


Attachments:
(No filename) (163.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments