2013-08-16 09:32:28

by Raghavendra K T

Subject: [PATCH trivial sparse fix] guest x86 kvm: fix sparse warning: symbol 'klock_waiting' was not declared. Should it be static

It was not declared as static since it was thought to be used by pv-flushtlb earlier.

Signed-off-by: Raghavendra K T <[email protected]>
---
This should apply on top of tip/spinlocks and fixes the sparse warning
introduced by pvspinlock patch series.

arch/x86/kernel/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index b8ef630..56e2fa4 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -529,7 +529,7 @@ arch_initcall(activate_jump_labels);
#ifdef CONFIG_PARAVIRT_SPINLOCKS

/* Kick a cpu by its apicid. Used to wake up a halted vcpu */
-void kvm_kick_cpu(int cpu)
+static void kvm_kick_cpu(int cpu)
{
int apicid;
unsigned long flags = 0;
--
1.7.11.7

2013-08-19 09:58:18

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/spinlocks] x86/kvm/guest: Fix sparse warning: "symbol ' klock_waiting' was not declared as static"

Commit-ID: 36bd621337c91a1ecda588e5bbbae8dd9698bae7
Gitweb: http://git.kernel.org/tip/36bd621337c91a1ecda588e5bbbae8dd9698bae7
Author: Raghavendra K T <[email protected]>
AuthorDate: Fri, 16 Aug 2013 15:08:41 +0530
Committer: Ingo Molnar <[email protected]>
CommitDate: Mon, 19 Aug 2013 11:49:50 +0200

x86/kvm/guest: Fix sparse warning: "symbol 'klock_waiting' was not declared as static"

It was not declared as static since it was thought to be used by
pv-flushtlb earlier.

Signed-off-by: Raghavendra K T <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: Jiri Kosina <[email protected]>
Link: http://lkml.kernel.org/r/1376645921-8056-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index b8ef630..56e2fa4 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -529,7 +529,7 @@ arch_initcall(activate_jump_labels);
#ifdef CONFIG_PARAVIRT_SPINLOCKS

/* Kick a cpu by its apicid. Used to wake up a halted vcpu */
-void kvm_kick_cpu(int cpu)
+static void kvm_kick_cpu(int cpu)
{
int apicid;
unsigned long flags = 0;