From: Jan-Simon Möller <[email protected]>
Author: PaX Team <pageexec at freemail.hu>
ML-Post: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
URL: http://llvm.linuxfoundation.org
Merge: Jan-Simon Möller <dl9pf at gmx.de>
Description:
Clang chokes on the notation "inl (%dx)" but works for "inl %dx"; GNU as accepts both forms.
Signed-off-by: Jan-Simon Möller <[email protected]>
CC: Arnd Bergmann <[email protected]>
CC: Greg Kroah-Hartman <[email protected]>
CC: [email protected]
---
drivers/misc/vmw_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index cb56e27..2421835 100644
--- a/drivers/misc/vmw_balloon.c
+++ b/drivers/misc/vmw_balloon.c
@@ -133,7 +133,7 @@ MODULE_LICENSE("GPL");
#define VMWARE_BALLOON_CMD(cmd, data, result) \
({ \
unsigned long __stat, __dummy1, __dummy2; \
- __asm__ __volatile__ ("inl (%%dx)" : \
+ __asm__ __volatile__ ("inl %%dx" : \
"=a"(__stat), \
"=c"(__dummy1), \
"=d"(__dummy2), \
--
1.8.1.4
On Tue, Aug 20, 2013 at 10:52:06PM +0200, [email protected] wrote:
> From: Jan-Simon M?ller <[email protected]>
>
> Author: PaX Team <pageexec at freemail.hu>
> ML-Post: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
> URL: http://llvm.linuxfoundation.org
>
> Merge: Jan-Simon M?ller <dl9pf at gmx.de>
What am I supposed to do with these?
> Description:
> Clang chokes on the notation "inl (%dx)" but works for "inl %dx"; GNU as accepts both forms.
No need for "description", that's implied by the body of the changelog
text. Also, you can wrap your lines :)
I'll clean this all up by hand, but please do this next time so I don't
have to.
thanks,
greg k-h
On Tuesday 20 August 2013 14:24:33 Greg Kroah-Hartman wrote:
> On Tue, Aug 20, 2013 at 10:52:06PM +0200, [email protected] wrote:
> > From: Jan-Simon M?ller <[email protected]>
> >
> > Author: PaX Team <pageexec at freemail.hu>
> > ML-Post:
> > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/1427
> > 07.html URL: http://llvm.linuxfoundation.org
> >
> > Merge: Jan-Simon M?ller <dl9pf at gmx.de>
>
> What am I supposed to do with these?
>
> > Description:
> > Clang chokes on the notation "inl (%dx)" but works for "inl %dx"; GNU as
> > accepts both forms.
> No need for "description", that's implied by the body of the changelog
> text. Also, you can wrap your lines :)
>
> I'll clean this all up by hand, but please do this next time so I don't
> have to.
Roger that - ignore it in the other 2 I just sent out. c'n'p from the
existing commit msg.
Do you want all 3 w/o then ?
JS
On Tue, Aug 20, 2013 at 11:26:01PM +0200, Jan-Simon M?ller wrote:
> On Tuesday 20 August 2013 14:24:33 Greg Kroah-Hartman wrote:
> > On Tue, Aug 20, 2013 at 10:52:06PM +0200, [email protected] wrote:
> > > From: Jan-Simon M?ller <[email protected]>
> > >
> > > Author: PaX Team <pageexec at freemail.hu>
> > > ML-Post:
> > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/1427
> > > 07.html URL: http://llvm.linuxfoundation.org
> > >
> > > Merge: Jan-Simon M?ller <dl9pf at gmx.de>
> >
> > What am I supposed to do with these?
> >
> > > Description:
> > > Clang chokes on the notation "inl (%dx)" but works for "inl %dx"; GNU as
> > > accepts both forms.
> > No need for "description", that's implied by the body of the changelog
> > text. Also, you can wrap your lines :)
> >
> > I'll clean this all up by hand, but please do this next time so I don't
> > have to.
>
> Roger that - ignore it in the other 2 I just sent out. c'n'p from the
> existing commit msg.
> Do you want all 3 w/o then ?
As the other two were not sent to me (I'm not a maintainer of those
areas of the kernel), I have no idea, sorry.
greg k-h