2013-08-21 07:17:12

by Libo Chen

Subject: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()

Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 01b0cc5..7f85143 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -433,8 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);

- dev_set_drvdata(dev, NULL);
-
kfree(data);

return 0;
--
1.7.1

2013-08-22 05:54:10

by Prabhakar

Subject: Re: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()

Hi Libo,

Thanks for the patch.

On Wed, Aug 21, 2013 at 12:32 PM, Libo Chen <[email protected]> wrote:
> Unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
>
> Signed-off-by: Libo Chen <[email protected]>

Acked-by: Lad, Prabhakar <[email protected]>

Regards,
--Prabhakar Lad