2013-08-21 08:30:59

by Peter Ujfalusi

Subject: [PATCH] power: twl4030-charger: Fix compiler warning with regulator_enable()

The return value of regulator_enable need to be checked. This patch fixes
the following warning:
drivers/power/twl4030_charger.c: In function ‘twl4030_charger_enable_usb’:
drivers/power/twl4030_charger.c:192:20: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/power/twl4030_charger.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
index be98e70..d98abe9 100644
--- a/drivers/power/twl4030_charger.c
+++ b/drivers/power/twl4030_charger.c
@@ -189,7 +189,12 @@ static int twl4030_charger_enable_usb(struct twl4030_bci *bci, bool enable)

/* Need to keep regulator on */
if (!bci->usb_enabled) {
- regulator_enable(bci->usb_reg);
+ ret = regulator_enable(bci->usb_reg);
+ if (ret) {
+ dev_err(bci->dev,
+ "Failed to enable regulator\n");
+ return ret;
+ }
bci->usb_enabled = 1;
}

--
1.8.3.2

2013-08-28 01:34:42

by Anton Vorontsov

Subject: Re: [PATCH] power: twl4030-charger: Fix compiler warning with regulator_enable()

On Wed, Aug 21, 2013 at 11:31:37AM +0300, Peter Ujfalusi wrote:
> The return value of regulator_enable need to be checked. This patch fixes
> the following warning:
> drivers/power/twl4030_charger.c: In function ‘twl4030_charger_enable_usb’:
> drivers/power/twl4030_charger.c:192:20: warning: ignoring return value of ‘regulator_enable’, declared with attribute warn_unused_result [-Wunused-result]
>
> Signed-off-by: Peter Ujfalusi <[email protected]>

Applied, thanks a lot!

Anton