2013-08-22 13:25:53

by Fabio Estevam

Subject: [PATCH] iommu: No need to pass '0x' when '%pa' is used

Commit 6197ca82 (iommu: Use %pa and %zx instead of casting) introduced the
usage of '%pa', but still kept the '0x', which leads to printing '0x0x'.

Remove the '0x' when '%pa' is used.

Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/iommu/iommu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index fbe9ca7..06d36a0 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -807,17 +807,17 @@ int iommu_map(struct iommu_domain *domain, unsigned long iova,
* size of the smallest page supported by the hardware
*/
if (!IS_ALIGNED(iova | paddr | size, min_pagesz)) {
- pr_err("unaligned: iova 0x%lx pa 0x%pa size 0x%zx min_pagesz 0x%x\n",
+ pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
iova, &paddr, size, min_pagesz);
return -EINVAL;
}

- pr_debug("map: iova 0x%lx pa 0x%pa size 0x%zx\n", iova, &paddr, size);
+ pr_debug("map: iova 0x%lx pa %pa size 0x%zx\n", iova, &paddr, size);

while (size) {
size_t pgsize = iommu_pgsize(domain, iova | paddr, size);

- pr_debug("mapping: iova 0x%lx pa 0x%pa pgsize 0x%zx\n",
+ pr_debug("mapping: iova 0x%lx pa %pa pgsize 0x%zx\n",
iova, &paddr, pgsize);

ret = domain->ops->map(domain, iova, paddr, pgsize, prot);
--
1.8.1.2

2013-08-22 13:38:54

by Joe Perches

Subject: Re: [PATCH] iommu: No need to pass '0x' when '%pa' is used

On Thu, 2013-08-22 at 10:25 -0300, Fabio Estevam wrote:
> Commit 6197ca82 (iommu: Use %pa and %zx instead of casting) introduced the
> usage of '%pa', but still kept the '0x', which leads to printing '0x0x'.
> Remove the '0x' when '%pa' is used.

And there are no other uses of "0x%pa" in current or -next.

Thanks Fabio.

2013-09-24 12:44:08

by Joerg Roedel

Subject: Re: [PATCH] iommu: No need to pass '0x' when '%pa' is used

On Thu, Aug 22, 2013 at 10:25:42AM -0300, Fabio Estevam wrote:
> Commit 6197ca82 (iommu: Use %pa and %zx instead of casting) introduced the
> usage of '%pa', but still kept the '0x', which leads to printing '0x0x'.
>
> Remove the '0x' when '%pa' is used.

Applied to core branch, thanks.