2013-08-23 11:35:36

by Sachin Kamat

Subject: [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration

Silences the following warning:
drivers/mfd/db8500-prcmu.c:2322:25: warning:
non-ANSI function declaration of function 'prcmu_ac_sleep_req'

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/mfd/db8500-prcmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 0d68eb1..8685872 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2319,7 +2319,7 @@ unlock_and_return:
/**
* prcmu_ac_sleep_req - called when ARM no longer needs to talk to modem
*/
-void prcmu_ac_sleep_req()
+void prcmu_ac_sleep_req(void)
{
u32 val;

--
1.7.4.1

2013-08-23 11:35:52

by Sachin Kamat

Subject: [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt

clk_mgt is used only in this file. Make it static.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/mfd/db8500-prcmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 8685872..53f371d 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -465,7 +465,7 @@ static DEFINE_SPINLOCK(clk_mgt_lock);

#define CLK_MGT_ENTRY(_name, _branch, _clk38div)[PRCMU_##_name] = \
{ (PRCM_##_name##_MGT), 0 , _branch, _clk38div}
-struct clk_mgt clk_mgt[PRCMU_NUM_REG_CLOCKS] = {
+static struct clk_mgt clk_mgt[PRCMU_NUM_REG_CLOCKS] = {
CLK_MGT_ENTRY(SGACLK, PLL_DIV, false),
CLK_MGT_ENTRY(UARTCLK, PLL_FIX, true),
CLK_MGT_ENTRY(MSP02CLK, PLL_FIX, true),
--
1.7.4.1

2013-08-23 18:57:05

by Linus Walleij

Subject: Re: [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration

On Fri, Aug 23, 2013 at 1:35 PM, Sachin Kamat <[email protected]> wrote:

> Silences the following warning:
> drivers/mfd/db8500-prcmu.c:2322:25: warning:
> non-ANSI function declaration of function 'prcmu_ac_sleep_req'
>
> Signed-off-by: Sachin Kamat <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2013-08-23 18:57:32

by Linus Walleij

Subject: Re: [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt

On Fri, Aug 23, 2013 at 1:35 PM, Sachin Kamat <[email protected]> wrote:

> clk_mgt is used only in this file. Make it static.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2013-08-27 08:27:25

by Lee Jones

Subject: Re: [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration

On Fri, 23 Aug 2013, Sachin Kamat wrote:

> Silences the following warning:
> drivers/mfd/db8500-prcmu.c:2322:25: warning:
> non-ANSI function declaration of function 'prcmu_ac_sleep_req'
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Applied with Linus' Ack.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2013-08-27 08:28:24

by Lee Jones

Subject: Re: [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt

On Fri, 23 Aug 2013, Sachin Kamat wrote:

> clk_mgt is used only in this file. Make it static.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Applied with Linus' Ack.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog