2013-08-24 00:34:47

by Li Bin

[permalink] [raw]
Subject: [PATCH] workqueue: remove unnecessary goto statement

Using return NULL to replace goto statement and avoiding a redundant
function call for free_workqueue_attrs(). If kzalloc for attrs of
struct workqueue_attrs is failed, alloc_workqueue_attrs return
NULL directedly. With no functional changs.

Signed-off-by: Libin <[email protected]>
---
kernel/workqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 7f5d4be..dabeb88 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3400,7 +3400,7 @@ struct workqueue_attrs *alloc_workqueue_attrs(gfp_t gfp_mask)

attrs = kzalloc(sizeof(*attrs), gfp_mask);
if (!attrs)
- goto fail;
+ return NULL;
if (!alloc_cpumask_var(&attrs->cpumask, gfp_mask))
goto fail;

--
1.8.2.1