2023-09-21 06:51:21

by Tree Davies

Subject: [PATCH 00/11] Staging: rtl8192e: Function and Variable rename series

This series fixes 11 checkpatch Avoid Camelcase issues throughout the
driver.

Thank you in advance to reviewers
Tree

Tree Davies (11):
Staging: rtl8192e: Rename variable Time
Staging: rtl8192e: Rename variable pAdmittedBa
Staging: rtl8192e: Rename variable pPendingBa
Staging: rtl8192e: Rename variable Dst
Staging: rtl8192e: Rename variable pPendingBA
Staging: rtl8192e: Rename variable Addr
Staging: rtl8192e: Rename variable pStatusCode
Staging: rtl8192e: Rename variable Policy
Staging: rtl8192e: Rename function GetTs()
Staging: rtl8192e: Rename function TSInitialize
Staging: rtl8192e: Rename variable StatusCode

drivers/staging/rtl8192e/rtl819x_BAProc.c | 74 +++++++++++------------
drivers/staging/rtl8192e/rtl819x_TS.h | 2 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c | 36 +++++------
drivers/staging/rtl8192e/rtllib.h | 8 +--
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
drivers/staging/rtl8192e/rtllib_rx.c | 4 +-
drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
7 files changed, 65 insertions(+), 65 deletions(-)

--
2.39.2

2023-09-21 07:09:57

by Tree Davies

Subject: [PATCH 04/11] Staging: rtl8192e: Rename variable Dst

Rename variable Dst to dst to fix checkpatch warning Avoid
CamelCase.

Signed-off-by: Tree Davies <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 5642e7788e42..621dbca7716a 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -63,7 +63,7 @@ void rtllib_reset_ba_entry(struct ba_record *pBA)
pBA->ba_start_seq_ctrl.short_data = 0;
}

-static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
+static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *dst,
struct ba_record *pBA,
u16 StatusCode, u8 type)
{
@@ -73,7 +73,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
u16 len = ieee->tx_headroom + 9;

netdev_dbg(ieee->dev, "%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n",
- __func__, type, Dst, ieee->dev);
+ __func__, type, dst, ieee->dev);

if (!pBA) {
netdev_warn(ieee->dev, "pBA is NULL\n");
@@ -89,7 +89,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,

BAReq = skb_put(skb, sizeof(struct ieee80211_hdr_3addr));

- ether_addr_copy(BAReq->addr1, Dst);
+ ether_addr_copy(BAReq->addr1, dst);
ether_addr_copy(BAReq->addr2, ieee->dev->dev_addr);

ether_addr_copy(BAReq->addr3, ieee->current_network.bssid);
--
2.39.2

2023-09-21 08:14:27

by Tree Davies

Subject: [PATCH 01/11] Staging: rtl8192e: Rename variable Time

Rename variable Time to time to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index a57673ecf791..fbac0e598cf9 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -10,11 +10,11 @@
#include "rtllib.h"
#include "rtl819x_BA.h"

-static void activate_ba_entry(struct ba_record *pBA, u16 Time)
+static void activate_ba_entry(struct ba_record *pBA, u16 time)
{
pBA->b_valid = true;
- if (Time != 0)
- mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time));
+ if (time != 0)
+ mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(time));
}

static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pBA)
--
2.39.2

2023-09-22 02:58:21

by Philipp Hortmann

Subject: Re: [PATCH 00/11] Staging: rtl8192e: Function and Variable rename series

On 9/21/23 05:25, Tree Davies wrote:
> This series fixes 11 checkpatch Avoid Camelcase issues throughout the
> driver.
>
> Thank you in advance to reviewers
> Tree
>
> Tree Davies (11):
> Staging: rtl8192e: Rename variable Time
> Staging: rtl8192e: Rename variable pAdmittedBa
> Staging: rtl8192e: Rename variable pPendingBa
> Staging: rtl8192e: Rename variable Dst
> Staging: rtl8192e: Rename variable pPendingBA
> Staging: rtl8192e: Rename variable Addr
> Staging: rtl8192e: Rename variable pStatusCode
> Staging: rtl8192e: Rename variable Policy
> Staging: rtl8192e: Rename function GetTs()
> Staging: rtl8192e: Rename function TSInitialize
> Staging: rtl8192e: Rename variable StatusCode
>
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 74 +++++++++++------------
> drivers/staging/rtl8192e/rtl819x_TS.h | 2 +-
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 36 +++++------
> drivers/staging/rtl8192e/rtllib.h | 8 +--
> drivers/staging/rtl8192e/rtllib_module.c | 2 +-
> drivers/staging/rtl8192e/rtllib_rx.c | 4 +-
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
> 7 files changed, 65 insertions(+), 65 deletions(-)
>


Tested-by: Philipp Hortmann <[email protected]>