2013-08-29 01:20:07

by Yanchuan Nian

[permalink] [raw]
Subject: [PATCH] mm/mmap: remove unnecessary assignment

From: Yanchuan Nian <[email protected]>

pgoff is not used after the statement "pgoff = vma->vm_pgoff;",
so the assignment is redundant.

Signed-off-by: Yanchuan Nian <[email protected]>
---
mm/mmap.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 2664a47..e7d7231 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1508,7 +1508,6 @@ munmap_back:
WARN_ON_ONCE(addr != vma->vm_start);

addr = vma->vm_start;
- pgoff = vma->vm_pgoff;
vm_flags = vma->vm_flags;
} else if (vm_flags & VM_SHARED) {
if (unlikely(vm_flags & (VM_GROWSDOWN|VM_GROWSUP)))
--
1.7.4.4


2013-08-29 06:24:44

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH] mm/mmap: remove unnecessary assignment

On Thu, 29 Aug 2013, Yanchuan Nian wrote:

> From: Yanchuan Nian <[email protected]>
>
> pgoff is not used after the statement "pgoff = vma->vm_pgoff;",
> so the assignment is redundant.
>
> Signed-off-by: Yanchuan Nian <[email protected]>

Acked-by: David Rientjes <[email protected]>