2013-08-29 20:14:16

by dbasehore .

Subject: [PATCH] iio: isl29018: Fix uninitialized value

The lux_uscale value is not initialized at probe. The value will be
uninitialized unless a value is written to it through the iio channel interface.
This fixes that.

Signed-off-by: Derek Basehore <[email protected]>
Reviewed-on: https://gerrit.chromium.org/gerrit/65998
---
drivers/staging/iio/light/isl29018.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 82478a5..28c6386 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -564,6 +564,7 @@ static int isl29018_probe(struct i2c_client *client,
mutex_init(&chip->lock);

chip->lux_scale = 1;
+ chip->lux_uscale = 0;
chip->range = 1000;
chip->adc_bit = 16;
chip->suspended = false;
--
1.8.4

2013-09-08 12:48:46

by Jonathan Cameron

Subject: Re: [PATCH] iio: isl29018: Fix uninitialized value

On 08/29/13 21:14, Derek Basehore wrote:
> The lux_uscale value is not initialized at probe. The value will be
> uninitialized unless a value is written to it through the iio channel interface.
> This fixes that.
>
> Signed-off-by: Derek Basehore <[email protected]>
> Reviewed-on: https://gerrit.chromium.org/gerrit/65998
Thanks,
Applied to the fixes-togreg branch of iio.git

I'll send this onwards in a few days.

Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 82478a5..28c6386 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -564,6 +564,7 @@ static int isl29018_probe(struct i2c_client *client,
> mutex_init(&chip->lock);
>
> chip->lux_scale = 1;
> + chip->lux_uscale = 0;
> chip->range = 1000;
> chip->adc_bit = 16;
> chip->suspended = false;
>