2013-09-10 15:54:46

by Adam Jackson

Subject: [PATCH] mei: Don't dev_err() on suspend

Suspend isn't an error condition, and I'm sick of seeing this (and only
this) on the console when I suspend with quiet boot enabled.

Signed-off-by: Adam Jackson <[email protected]>
---
drivers/misc/mei/pci-me.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 1b3844e..c718f1d 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;

- dev_err(&pdev->dev, "suspend\n");
+ dev_info(&pdev->dev, "suspend\n");

mei_stop(dev);

--
1.8.3.1

2013-09-10 16:06:31

by Joe Perches

Subject: Re: [PATCH] mei: Don't dev_err() on suspend

On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> Suspend isn't an error condition, and I'm sick of seeing this (and only
> this) on the console when I suspend with quiet boot enabled.
[]
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
[]
> @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> if (!dev)
> return -ENODEV;
>
> - dev_err(&pdev->dev, "suspend\n");
> + dev_info(&pdev->dev, "suspend\n");

dev_dbg instead?

2013-09-10 16:37:51

by Tomas Winkler

Subject: RE: [PATCH] mei: Don't dev_err() on suspend

I

> -----Original Message-----
> From: Joe Perches [mailto:[email protected]]
> Sent: Tuesday, September 10, 2013 19:06
> To: Adam Jackson
> Cc: [email protected]; Winkler, Tomas
> Subject: Re: [PATCH] mei: Don't dev_err() on suspend
>
> On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> > Suspend isn't an error condition, and I'm sick of seeing this (and only
> > this) on the console when I suspend with quiet boot enabled.
> []
> > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> []
> > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> > if (!dev)
> > return -ENODEV;
> >
> > - dev_err(&pdev->dev, "suspend\n");
> > + dev_info(&pdev->dev, "suspend\n");
>
> dev_dbg instead?

Yes, but I believe we fixed that long ago were do you see this?
Thanks
Tomas

2013-09-10 16:47:27

by Joe Perches

Subject: Re: [PATCH] mei: Don't dev_err() on suspend

On Tue, 2013-09-10 at 16:37 +0000, Winkler, Tomas wrote:
> From: Joe Perches [mailto:[email protected]]
> > On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> > > Suspend isn't an error condition, and I'm sick of seeing this (and only
> > > this) on the console when I suspend with quiet boot enabled.
> > []
> > > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> > []
> > > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> > > if (!dev)
> > > return -ENODEV;
> > >
> > > - dev_err(&pdev->dev, "suspend\n");
> > > + dev_info(&pdev->dev, "suspend\n");
> >
> > dev_dbg instead?
>
> Yes, but I believe we fixed that long ago were do you see this?

drivers/misc/mei/pci-me.c of both linus and -next