2013-09-11 15:57:04

by Aravind Gopalakrishnan

Subject: [PATCH] EDAC, AMD64_EDAC: Remove superfluous condition check.

The condition check 'channel < 0' is needless since channel is unsigned.

Reported by Dave Jones here:
http://marc.info/?l=linux-kernel&m=137839225430844&w=2

Signed-off-by: Aravind Gopalakrishnan <[email protected]>
---
drivers/edac/amd64_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 3c9e4e9..bbd1913 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1576,7 +1576,7 @@ static int f15_m30h_match_to_this_node(struct amd64_pvt *pvt, unsigned range,
num_dcts_intlv, dct_sel);

/* Verify we stay within the MAX number of channels allowed */
- if (channel > 4 || channel < 0)
+ if (channel > 4)
return -EINVAL;

leg_mmio_hole = (u8) (dct_cont_base_reg >> 1 & BIT(0));
--
1.7.10.4

2013-09-19 09:12:11

by Borislav Petkov

Subject: Re: [PATCH] EDAC, AMD64_EDAC: Remove superfluous condition check.

On Wed, Sep 11, 2013 at 10:55:58AM -0500, Aravind Gopalakrishnan wrote:
> The condition check 'channel < 0' is needless since channel is unsigned.
>
> Reported by Dave Jones here:
> http://marc.info/?l=linux-kernel&m=137839225430844&w=2
>
> Signed-off-by: Aravind Gopalakrishnan <[email protected]>

Applied, thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--