2013-09-13 23:23:15

by Valentin Ilie

[permalink] [raw]

Subject: [PATCH] ASoC: blackfin: Add missing break statement to bf6xx

---

SNDRV_PCM_FORMAT_S8 isn't supposed to fall through to SNDRV_PCM_FORMAT_S16_LE

Signed-off-by: Valentin Ilie <[email protected]>
---
sound/soc/blackfin/bf6xx-i2s.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/blackfin/bf6xx-i2s.c b/sound/soc/blackfin/bf6xx-i2s.c
index c02405c..5810a06 100644
--- a/sound/soc/blackfin/bf6xx-i2s.c
+++ b/sound/soc/blackfin/bf6xx-i2s.c
@@ -88,6 +88,7 @@ static int bfin_i2s_hw_params(struct snd_pcm_substream *substream,
case SNDRV_PCM_FORMAT_S8:
param.spctl |= 0x70;
sport->wdsize = 1;
+ break;
case SNDRV_PCM_FORMAT_S16_LE:
param.spctl |= 0xf0;
sport->wdsize = 2;
--
1.7.9.5

2013-09-16 23:48:13

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] ASoC: blackfin: Add missing break statement to bf6xx

---

On Sat, Sep 14, 2013 at 02:20:37AM +0300, Valentin Ilie wrote:
> SNDRV_PCM_FORMAT_S8 isn't supposed to fall through to SNDRV_PCM_FORMAT_S16_LE
>
> Signed-off-by: Valentin Ilie <[email protected]>

Applied, thanks.

---

Attachments:

(No filename) (221.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments