2013-09-16 20:51:47

by Vincent Stehlé

Subject: [PATCH linux-next] pinctrl: fix pinconf_dbg_config_write return type

Have pinconf_dbg_config_write() return a ssize_t. This fixes the following
compilation warning:

drivers/pinctrl/pinconf.c:617:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/pinctrl/pinconf.c:617:2: warning: (near initialization for ‘pinconf_dbg_pinconfig_fops.write’) [enabled by default]

Signed-off-by: Vincent Stehlé <[email protected]>
Cc: Linus Walleij <[email protected]>
---

Hi,

This can be seen with e.g. next-20130916 with x86 allmodconfig.

Best regards,

V.

drivers/pinctrl/pinconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a138965..1664e78 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -490,7 +490,7 @@ exit:
* <devicename> <state> <pinname> are values that should match the pinctrl-maps
* <newvalue> reflects the new config and is driver dependant
*/
-static int pinconf_dbg_config_write(struct file *file,
+static ssize_t pinconf_dbg_config_write(struct file *file,
const char __user *user_buf, size_t count, loff_t *ppos)
{
struct pinctrl_maps *maps_node;
--
1.8.4.rc3

2013-09-23 08:45:35

by Linus Walleij

Subject: Re: [PATCH linux-next] pinctrl: fix pinconf_dbg_config_write return type

On Mon, Sep 16, 2013 at 10:50 PM, Vincent Stehl?
<[email protected]> wrote:

> Have pinconf_dbg_config_write() return a ssize_t. This fixes the following
> compilation warning:
>
> drivers/pinctrl/pinconf.c:617:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/pinctrl/pinconf.c:617:2: warning: (near initialization for ?pinconf_dbg_pinconfig_fops.write?) [enabled by default]
>
> Signed-off-by: Vincent Stehl? <[email protected]>
> Cc: Linus Walleij <[email protected]>

Patch applied!

Yours,
Linus Walleij