2013-09-17 07:25:43

by Liu, Chuansheng

Subject: [PATCH] ahci: Changing two module params with static and __read_mostly

Here module parameters ahci_em_messages and devslp_idle_timeout can
be set as static and __read_mostly.

Signed-off-by: Liu, Chuansheng <[email protected]>
---
drivers/ata/libahci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index acfd0f7..1757631 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -189,14 +189,15 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
};
EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);

-int ahci_em_messages = 1;
+static int ahci_em_messages __read_mostly = 1;
EXPORT_SYMBOL_GPL(ahci_em_messages);
module_param(ahci_em_messages, int, 0444);
/* add other LED protocol types when they become supported */
MODULE_PARM_DESC(ahci_em_messages,
"AHCI Enclosure Management Message control (0 = off, 1 = on)");

-int devslp_idle_timeout = 1000; /* device sleep idle timeout in ms */
+/* device sleep idle timeout in ms */
+static int devslp_idle_timeout __read_mostly = 1000;
module_param(devslp_idle_timeout, int, 0644);
MODULE_PARM_DESC(devslp_idle_timeout, "device sleep idle timeout");

--
1.7.9.5

2013-09-17 16:24:30

by Joe Perches

Subject: Re: [PATCH] ahci: Changing two module params with static and __read_mostly

On Wed, 2013-09-18 at 00:48 +0800, Chuansheng Liu wrote:
> Here module parameters ahci_em_messages and devslp_idle_timeout can
> be set as static and __read_mostly.
>
> Signed-off-by: Liu, Chuansheng <[email protected]>
> ---
> drivers/ata/libahci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
[]
> @@ -189,14 +189,15 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
> };
> EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
>
> -int ahci_em_messages = 1;
> +static int ahci_em_messages __read_mostly = 1;

This one could also be converted to
static bool ahci_em_messages __read_mostly = true;

2013-09-18 02:52:07

by Liu, Chuansheng

Subject: RE: [PATCH] ahci: Changing two module params with static and __read_mostly

> -----Original Message-----
> From: Joe Perches [mailto:[email protected]]
> Sent: Wednesday, September 18, 2013 12:24 AM
> To: Liu, Chuansheng
> Cc: [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH] ahci: Changing two module params with static and
> __read_mostly
>
> On Wed, 2013-09-18 at 00:48 +0800, Chuansheng Liu wrote:
> > Here module parameters ahci_em_messages and devslp_idle_timeout can
> > be set as static and __read_mostly.
> >
> > Signed-off-by: Liu, Chuansheng <[email protected]>
> > ---
> > drivers/ata/libahci.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> []
> > @@ -189,14 +189,15 @@ struct ata_port_operations
> ahci_pmp_retry_srst_ops = {
> > };
> > EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
> >
> > -int ahci_em_messages = 1;
> > +static int ahci_em_messages __read_mostly = 1;
>
> This one could also be converted to
> static bool ahci_em_messages __read_mostly = true;
>
Thanks, will update one new patch.

2013-09-18 02:59:23

by Liu, Chuansheng

Subject: [PATCH V2] ahci: Changing two module params with static and __read_mostly

Here module parameters ahci_em_messages and devslp_idle_timeout can
be set as static and __read_mostly.

Signed-off-by: Liu, Chuansheng <[email protected]>
---
drivers/ata/libahci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index acfd0f7..b67086f 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -189,14 +189,15 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
};
EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);

-int ahci_em_messages = 1;
+static bool ahci_em_messages __read_mostly = true;
EXPORT_SYMBOL_GPL(ahci_em_messages);
-module_param(ahci_em_messages, int, 0444);
+module_param(ahci_em_messages, bool, 0444);
/* add other LED protocol types when they become supported */
MODULE_PARM_DESC(ahci_em_messages,
"AHCI Enclosure Management Message control (0 = off, 1 = on)");

-int devslp_idle_timeout = 1000; /* device sleep idle timeout in ms */
+/* device sleep idle timeout in ms */
+static int devslp_idle_timeout __read_mostly = 1000;
module_param(devslp_idle_timeout, int, 0644);
MODULE_PARM_DESC(devslp_idle_timeout, "device sleep idle timeout");

--
1.7.9.5

2013-09-22 16:54:26

by Tejun Heo

Subject: Re: [PATCH V2] ahci: Changing two module params with static and __read_mostly

On Wed, Sep 18, 2013 at 08:21:49PM +0800, Chuansheng Liu wrote:
>
> Here module parameters ahci_em_messages and devslp_idle_timeout can
> be set as static and __read_mostly.
>
> Signed-off-by: Liu, Chuansheng <[email protected]>

Applied to libata/for-3.13. Thanks.

--
tejun