2013-09-19 12:41:01

by Matt Porter

[permalink] [raw]
Subject: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support

Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
UART and FEC enabled.

Signed-off-by: Matt Porter <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index cc0f1fb..b0d6156 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
imx6q-sbc6x.dtb \
imx6q-wandboard.dtb \
imx6sl-evk.dtb \
+ vf610-cosmic.dtb \
vf610-twr.dtb
dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
imx23-olinuxino.dtb \
diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
new file mode 100644
index 0000000..c3bd4d4f
--- /dev/null
+++ b/arch/arm/boot/dts/vf610-cosmic.dts
@@ -0,0 +1,46 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ * Copyright 2013 Linaro Limited
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+/dts-v1/;
+#include "vf610.dtsi"
+
+/ {
+ model = "PHYTEC Cosmic/Cosmic+ Board";
+ compatible = "phytec,vf610-cosmic", "fsl,vf610";
+
+ chosen {
+ bootargs = "console=ttyLP1,115200";
+ };
+
+ memory {
+ reg = <0x80000000 0x10000000>;
+ };
+
+ clocks {
+ enet_ext {
+ compatible = "fixed-clock";
+ clock-frequency = <50000000>;
+ };
+ };
+
+};
+
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart1_1>;
+ status = "okay";
+};
+
+&fec1 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1_1>;
+ status = "okay";
+};
--
1.8.4


2013-09-22 07:01:55

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support

On Thu, Sep 19, 2013 at 08:40:44AM -0400, Matt Porter wrote:
> Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
> UART and FEC enabled.
>
> Signed-off-by: Matt Porter <[email protected]>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
> create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index cc0f1fb..b0d6156 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
> imx6q-sbc6x.dtb \
> imx6q-wandboard.dtb \
> imx6sl-evk.dtb \
> + vf610-cosmic.dtb \
> vf610-twr.dtb
> dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
> imx23-olinuxino.dtb \
> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
> new file mode 100644
> index 0000000..c3bd4d4f
> --- /dev/null
> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
> @@ -0,0 +1,46 @@
> +/*
> + * Copyright 2013 Freescale Semiconductor, Inc.
> + * Copyright 2013 Linaro Limited
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
> +
> +/dts-v1/;
> +#include "vf610.dtsi"
> +
> +/ {
> + model = "PHYTEC Cosmic/Cosmic+ Board";
> + compatible = "phytec,vf610-cosmic", "fsl,vf610";
> +
> + chosen {
> + bootargs = "console=ttyLP1,115200";
> + };
> +
> + memory {
> + reg = <0x80000000 0x10000000>;
> + };
> +
> + clocks {
> + enet_ext {
> + compatible = "fixed-clock";
> + clock-frequency = <50000000>;
> + };

This is probably copied from vf610-twr.dts. But per
Documentation/devicetree/bindings/clock/fixed-clock.txt, #clock-cells is
a required property.

> + };
> +
> +};
> +
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart1_1>;
> + status = "okay";
> +};
> +
> +&fec1 {

Please sort the nodes alphabetically in label name.

Shawn

> + phy-mode = "rmii";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_fec1_1>;
> + status = "okay";
> +};
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2013-09-23 14:57:11

by Matt Porter

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: add initial VF610 Cosmic/Cosmic+ board support

On 09/22/2013 03:01 AM, Shawn Guo wrote:
> On Thu, Sep 19, 2013 at 08:40:44AM -0400, Matt Porter wrote:
>> Add initial PHYTEC VF610 Cosmic/Cosmic+ board support with
>> UART and FEC enabled.
>>
>> Signed-off-by: Matt Porter <[email protected]>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/vf610-cosmic.dts | 46 ++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 47 insertions(+)
>> create mode 100644 arch/arm/boot/dts/vf610-cosmic.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index cc0f1fb..b0d6156 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -142,6 +142,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>> imx6q-sbc6x.dtb \
>> imx6q-wandboard.dtb \
>> imx6sl-evk.dtb \
>> + vf610-cosmic.dtb \
>> vf610-twr.dtb
>> dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>> imx23-olinuxino.dtb \
>> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts b/arch/arm/boot/dts/vf610-cosmic.dts
>> new file mode 100644
>> index 0000000..c3bd4d4f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
>> @@ -0,0 +1,46 @@
>> +/*
>> + * Copyright 2013 Freescale Semiconductor, Inc.
>> + * Copyright 2013 Linaro Limited
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +
>> +/dts-v1/;
>> +#include "vf610.dtsi"
>> +
>> +/ {
>> + model = "PHYTEC Cosmic/Cosmic+ Board";
>> + compatible = "phytec,vf610-cosmic", "fsl,vf610";
>> +
>> + chosen {
>> + bootargs = "console=ttyLP1,115200";
>> + };
>> +
>> + memory {
>> + reg = <0x80000000 0x10000000>;
>> + };
>> +
>> + clocks {
>> + enet_ext {
>> + compatible = "fixed-clock";
>> + clock-frequency = <50000000>;
>> + };
>
> This is probably copied from vf610-twr.dts. But per
> Documentation/devicetree/bindings/clock/fixed-clock.txt, #clock-cells is
> a required property.

Indeed, will update it.

>
>> + };
>> +
>> +};
>> +
>> +&uart1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_uart1_1>;
>> + status = "okay";
>> +};
>> +
>> +&fec1 {
>
> Please sort the nodes alphabetically in label name.

Will do.

Thanks,
Matt