2013-09-20 22:52:33

by Daniel Walker

Subject: [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init

If the opstate_init() isn't called the driver won't start properly.

I just added it in what appears to be an appropriate place.

Signed-off-by: Daniel Walker <[email protected]>
---
drivers/edac/octeon_edac-lmc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/edac/octeon_edac-lmc.c b/drivers/edac/octeon_edac-lmc.c
index 93412d6..4881ad0 100644
--- a/drivers/edac/octeon_edac-lmc.c
+++ b/drivers/edac/octeon_edac-lmc.c
@@ -92,6 +92,8 @@ static int octeon_lmc_edac_probe(struct platform_device *pdev)
struct edac_mc_layer layers[1];
int mc = pdev->id;

+ opstate_init();
+
layers[0].type = EDAC_MC_LAYER_CHANNEL;
layers[0].size = 1;
layers[0].is_virt_csrow = false;
--
1.8.1.2

2013-09-24 12:32:25

by Ralf Baechle

Subject: Re: [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init

On Fri, Sep 20, 2013 at 03:46:40PM -0700, Daniel Walker wrote:

> If the opstate_init() isn't called the driver won't start properly.
>
> I just added it in what appears to be an appropriate place.
>
> Signed-off-by: Daniel Walker <[email protected]>

Makes sense. Unfortunately :-)

Acked-by: Ralf Baechle <[email protected]>

EDAC folks - I can funnel this patch through my tree or leave that to you,
whatever you prefer. Same for Daniel's other patch.

Ralf