2013-09-22 11:06:24

by Hanjun Guo

[permalink] [raw]
Subject: [PATCH] Staging / quickstart: remove reduplicate if(acpi_disabled) check

In acpi_bus_register_driver(), there is an if (acpi_disabled) check,
so the if(acpi_disabled) before it is reduplicate, remove it.

Signed-off-by: Hanjun Guo <[email protected]>
---
drivers/staging/quickstart/quickstart.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
index 4247d60..9f6ebdb 100644
--- a/drivers/staging/quickstart/quickstart.c
+++ b/drivers/staging/quickstart/quickstart.c
@@ -390,10 +390,6 @@ static int __init quickstart_init(void)
{
int ret;

- /* ACPI Check */
- if (acpi_disabled)
- return -ENODEV;
-
/* ACPI driver register */
ret = acpi_bus_register_driver(&quickstart_acpi_driver);
if (ret)
--
1.7.9.5


2013-09-25 23:52:11

by Toshi Kani

[permalink] [raw]
Subject: Re: [PATCH] Staging / quickstart: remove reduplicate if(acpi_disabled) check

On Sun, 2013-09-22 at 11:05 +0000, Hanjun Guo wrote:
> In acpi_bus_register_driver(), there is an if (acpi_disabled) check,
> so the if(acpi_disabled) before it is reduplicate, remove it.
>
> Signed-off-by: Hanjun Guo <[email protected]>

Acked-by: Toshi Kani <[email protected]>

-Toshi

> ---
> drivers/staging/quickstart/quickstart.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> index 4247d60..9f6ebdb 100644
> --- a/drivers/staging/quickstart/quickstart.c
> +++ b/drivers/staging/quickstart/quickstart.c
> @@ -390,10 +390,6 @@ static int __init quickstart_init(void)
> {
> int ret;
>
> - /* ACPI Check */
> - if (acpi_disabled)
> - return -ENODEV;
> -
> /* ACPI driver register */
> ret = acpi_bus_register_driver(&quickstart_acpi_driver);
> if (ret)