2013-09-23 09:46:06

by Mateusz Krawczuk

[permalink] [raw]
Subject: [PATCH] spi: s3c64xx: Add missing compatibles

Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.

Signed-off-by: Mateusz Krawczuk <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
drivers/spi/spi-s3c64xx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 8bed27a..84cc6ac 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1612,6 +1612,18 @@ static struct platform_device_id s3c64xx_spi_driver_ids[] = {
};

static const struct of_device_id s3c64xx_spi_dt_match[] = {
+ { .compatible = "samsung,s3c2443-spi",
+ .data = (void *)&s3c2443_spi_port_config,
+ },
+ { .compatible = "samsung,s3c6410-spi",
+ .data = (void *)&s3c6410_spi_port_config,
+ },
+ { .compatible = "samsung,s5pc100-spi",
+ .data = (void *)&s5pc100_spi_port_config,
+ },
+ { .compatible = "samsung,s5pv210-spi",
+ .data = (void *)&s5pv210_spi_port_config,
+ },
{ .compatible = "samsung,exynos4210-spi",
.data = (void *)&exynos4_spi_port_config,
},
--
1.8.1.2


2013-09-23 13:51:25

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: s3c64xx: Add missing compatibles

On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.

> static const struct of_device_id s3c64xx_spi_dt_match[] = {
> + { .compatible = "samsung,s3c2443-spi",
> + .data = (void *)&s3c2443_spi_port_config,
> + },
> + { .compatible = "samsung,s3c6410-spi",
> + .data = (void *)&s3c6410_spi_port_config,
> + },

This is missing s3c6400 and at least one other s3c24xx I think. They
can be added later though so applied, thanks.


Attachments:
(No filename) (510.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2013-09-23 14:04:08

by Tomasz Figa

[permalink] [raw]
Subject: Re: [PATCH] spi: s3c64xx: Add missing compatibles

Hi Mark,

On Monday 23 of September 2013 14:50:42 Mark Brown wrote:
> On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> > Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
>
> > static const struct of_device_id s3c64xx_spi_dt_match[] = {
> > + { .compatible = "samsung,s3c2443-spi",
> > + .data = (void *)&s3c2443_spi_port_config,
> > + },
> > + { .compatible = "samsung,s3c6410-spi",
> > + .data = (void *)&s3c6410_spi_port_config,
> > + },
>
> This is missing s3c6400 and at least one other s3c24xx I think. They
> can be added later though so applied, thanks.

I think after this patch the table lists all the SoC variants supported
by the driver, at least it's what I can tell from a quick look at
s3c64xx_spi_driver_ids[] array.

The compatible for S3C64xx should be probably called "samsung,s3c6400",
though, as it's the first SoC with this variant.

Best regards,
Tomasz


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part.