2021-03-01 17:42:20

by Chen-Yu Tsai

[permalink] [raw]
Subject: [PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices

From: Chen-Yu Tsai <[email protected]>

The macros for the clock and reset indices for the RSB hardware block
were replaced with raw numbers when the RSB controller node was added.
This was done to avoid cross-tree dependencies.

Now that both the clk and DT changes have been merged, we can switch
back to using the macros.

Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
Signed-off-by: Chen-Yu Tsai <[email protected]>
---

Small patch split out from the H6 RSB clock support patch.
This should be merged for v5.12.

---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 49e979794094..af8b7d0ef750 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -995,9 +995,9 @@ r_rsb: rsb@7083000 {
compatible = "allwinner,sun8i-a23-rsb";
reg = <0x07083000 0x400>;
interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&r_ccu 13>;
+ clocks = <&r_ccu CLK_R_APB2_RSB>;
clock-frequency = <3000000>;
- resets = <&r_ccu 7>;
+ resets = <&r_ccu RST_R_APB2_RSB>;
pinctrl-names = "default";
pinctrl-0 = <&r_rsb_pins>;
status = "disabled";
--
2.30.1


2021-03-02 21:48:49

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices

Hi,

On Tue, Mar 02, 2021 at 12:23:09AM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <[email protected]>
>
> The macros for the clock and reset indices for the RSB hardware block
> were replaced with raw numbers when the RSB controller node was added.
> This was done to avoid cross-tree dependencies.
>
> Now that both the clk and DT changes have been merged, we can switch
> back to using the macros.
>
> Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
> Signed-off-by: Chen-Yu Tsai <[email protected]>
> ---
>
> Small patch split out from the H6 RSB clock support patch.
> This should be merged for v5.12.

It's not really a fix but something we can live with, so I've merged it
to sunxi/dt-for-5.13

Thanks!
Maxime


Attachments:
(No filename) (769.00 B)
signature.asc (235.00 B)
Download all attachments

2021-03-03 05:57:33

by Jernej Skrabec

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: allwinner: h6: Switch to macros for RSB clock/reset indices

Hi Chen-Yu,

Dne ponedeljek, 01. marec 2021 ob 17:23:09 CET je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <[email protected]>
>
> The macros for the clock and reset indices for the RSB hardware block
> were replaced with raw numbers when the RSB controller node was added.
> This was done to avoid cross-tree dependencies.
>
> Now that both the clk and DT changes have been merged, we can switch
> back to using the macros.
>
> Fixes: aaad900757a6 ("arm64: dts: allwinner: h6: Add RSB controller node")
> Signed-off-by: Chen-Yu Tsai <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej