'break' after return has no effect. Remove it.
Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/regulator/wm8994-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c
index 71c5911..ffc1b2f 100644
--- a/drivers/regulator/wm8994-regulator.c
+++ b/drivers/regulator/wm8994-regulator.c
@@ -63,7 +63,6 @@ static int wm8994_ldo2_list_voltage(struct regulator_dev *rdev,
default:
return (selector * 100000) + 950000;
}
- break;
default:
return -EINVAL;
}
--
1.7.9.5
'break' after goto has no effect. Remove it.
Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/regulator/gpio-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 98a98ff..04406a9 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -283,7 +283,6 @@ static int gpio_regulator_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "No regulator type set\n");
ret = -EINVAL;
goto err_memgpio;
- break;
}
drvdata->nr_gpios = config->nr_gpios;
--
1.7.9.5
On Fri, Oct 04, 2013 at 03:18:17PM +0530, Sachin Kamat wrote:
> default:
> return (selector * 100000) + 950000;
> }
> - break;
> default:
I'm not sure this is actually a clarity improvement. While the break is
redundant the return statements are all inside the nested switch so it's
not entirely obvious at a glance that all the paths were covered.
On Fri, Oct 04, 2013 at 03:18:18PM +0530, Sachin Kamat wrote:
> 'break' after goto has no effect. Remove it.
Applied, thanks.