2013-10-06 10:32:47

by Ramkumar Ramachandra

Subject: [PATCH] perf tool: don't open-code TEST_EVENTS macro

The TEST_EVENTS macro is open-coded towards the end of
test__parse_events(). While at it, undef it cleanly after its usage.

Cc: Robert Richter <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
tools/perf/tests/parse-events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 48114d1..a6f51ff 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -1531,9 +1531,9 @@ do { \
return ret;
}

- ret1 = test_terms(test__terms, ARRAY_SIZE(test__terms));
- if (!ret2)
- ret2 = ret1;
+ TEST_EVENTS(test__terms);
+
+#undef TEST_EVENTS

return ret2;
}
--
1.8.4.477.g5d89aa9

2013-10-06 11:15:24

by Ramkumar Ramachandra

Subject: Re: [PATCH] perf tool: don't open-code TEST_EVENTS macro

Ramkumar Ramachandra wrote:
> The TEST_EVENTS macro is open-coded towards the end of
> test__parse_events(). While at it, undef it cleanly after its usage.

Kindly ignore this patch; I made a trivial mistake.