2013-10-10 02:00:37

by Felipe Pena

Subject: [PATCH] tools/perf/tests: Fix memory leak in dso-data.c

Fix for a memory leak on test_file() function in dso-data.c

Signed-off-by: Felipe Pena <[email protected]>
---
tools/perf/tests/dso-data.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index dffe055..9cc81a3 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -35,6 +35,7 @@ static char *test_file(int size)
if (size != write(fd, buf, size))
templ = NULL;

+ free(buf);
close(fd);
return templ;
}
--
1.7.10.4

2013-10-10 07:15:26

by Jiri Olsa

Subject: Re: [PATCH] tools/perf/tests: Fix memory leak in dso-data.c

On Wed, Oct 09, 2013 at 11:00:38PM -0300, Felipe Pena wrote:
> Fix for a memory leak on test_file() function in dso-data.c

oops, thanks ;-)

Acked-by: Jiri Olsa <[email protected]>

>
> Signed-off-by: Felipe Pena <[email protected]>
> ---
> tools/perf/tests/dso-data.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index dffe055..9cc81a3 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -35,6 +35,7 @@ static char *test_file(int size)
> if (size != write(fd, buf, size))
> templ = NULL;
>
> + free(buf);
> close(fd);
> return templ;
> }
> --
> 1.7.10.4
>

2013-10-15 05:33:29

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf tests: Fix memory leak in dso-data.c

Commit-ID: 1df9297c8535a5bb2b776381e63d8334f87d4abe
Gitweb: http://git.kernel.org/tip/1df9297c8535a5bb2b776381e63d8334f87d4abe
Author: Felipe Pena <[email protected]>
AuthorDate: Wed, 9 Oct 2013 23:00:38 -0300
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 14 Oct 2013 10:28:54 -0300

perf tests: Fix memory leak in dso-data.c

Fix for a memory leak on test_file() function in dso-data.c.

Signed-off-by: Felipe Pena <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/tests/dso-data.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index dffe055..9cc81a3 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -35,6 +35,7 @@ static char *test_file(int size)
if (size != write(fd, buf, size))
templ = NULL;

+ free(buf);
close(fd);
return templ;
}