2013-10-11 12:28:34

by Matias Bjørling

Subject: [PATCH] Export percpu-refcount functions

ERROR: "percpu_ref_kill_and_confirm" [...] undefined!

Working on a driver that needs them, but other modules might benefit as well.

Matias Bjorling (1):
percpu-refcount: Export symbols

lib/percpu-refcount.c | 3 +++
1 file changed, 3 insertions(+)

--
1.8.1.2

2013-10-11 12:28:49

by Matias Bjørling

Subject: [PATCH] percpu-refcount: Export symbols

Need to be exported for being used within modules.

Signed-off-by: Matias Bjorling <[email protected]>
---
lib/percpu-refcount.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c
index 7deeb62..25b9ac7 100644
--- a/lib/percpu-refcount.c
+++ b/lib/percpu-refcount.c
@@ -53,6 +53,7 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release)
ref->release = release;
return 0;
}
+EXPORT_SYMBOL(percpu_ref_init);

/**
* percpu_ref_cancel_init - cancel percpu_ref_init()
@@ -84,6 +85,7 @@ void percpu_ref_cancel_init(struct percpu_ref *ref)
free_percpu(ref->pcpu_count);
}
}
+EXPORT_SYMBOL(percpu_ref_cancel_init);

static void percpu_ref_kill_rcu(struct rcu_head *rcu)
{
@@ -156,3 +158,4 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref,

call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu);
}
+EXPORT_SYMBOL(percpu_ref_kill_and_confirm);
--
1.8.1.2

2013-10-13 11:09:33

by Paul E. McKenney

Subject: Re: [PATCH] percpu-refcount: Export symbols

On Fri, Oct 11, 2013 at 02:28:12PM +0200, Matias Bjorling wrote:
> Need to be exported for being used within modules.
>
> Signed-off-by: Matias Bjorling <[email protected]>

I will bite... Why not EXPORT_SYMBOL_GPL()?

Thanx, Paul

> ---
> lib/percpu-refcount.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c
> index 7deeb62..25b9ac7 100644
> --- a/lib/percpu-refcount.c
> +++ b/lib/percpu-refcount.c
> @@ -53,6 +53,7 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release)
> ref->release = release;
> return 0;
> }
> +EXPORT_SYMBOL(percpu_ref_init);
>
> /**
> * percpu_ref_cancel_init - cancel percpu_ref_init()
> @@ -84,6 +85,7 @@ void percpu_ref_cancel_init(struct percpu_ref *ref)
> free_percpu(ref->pcpu_count);
> }
> }
> +EXPORT_SYMBOL(percpu_ref_cancel_init);
>
> static void percpu_ref_kill_rcu(struct rcu_head *rcu)
> {
> @@ -156,3 +158,4 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref,
>
> call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu);
> }
> +EXPORT_SYMBOL(percpu_ref_kill_and_confirm);
> --
> 1.8.1.2
>

2013-10-13 17:01:13

by Tejun Heo

Subject: Re: [PATCH] percpu-refcount: Export symbols

On Sun, Oct 13, 2013 at 04:09:25AM -0700, Paul E. McKenney wrote:
> On Fri, Oct 11, 2013 at 02:28:12PM +0200, Matias Bjorling wrote:
> > Need to be exported for being used within modules.
> >
> > Signed-off-by: Matias Bjorling <[email protected]>
>
> I will bite... Why not EXPORT_SYMBOL_GPL()?

Seconded. Please use EXPORT_SYMBOL_GPL.

Thanks.

--
tejun