2013-10-13 03:59:56

by Michael Opdenacker

[permalink] [raw]
Subject: [PATCH] ipmi: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <[email protected]>
---
drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 15e4a60..68c5ef5 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1358,7 +1358,7 @@ static int std_irq_setup(struct smi_info *info)
if (info->si_type == SI_BT) {
rv = request_irq(info->irq,
si_bt_irq_handler,
- IRQF_SHARED | IRQF_DISABLED,
+ IRQF_SHARED,
DEVICE_NAME,
info);
if (!rv)
@@ -1368,7 +1368,7 @@ static int std_irq_setup(struct smi_info *info)
} else
rv = request_irq(info->irq,
si_irq_handler,
- IRQF_SHARED | IRQF_DISABLED,
+ IRQF_SHARED,
DEVICE_NAME,
info);
if (rv) {
--
1.8.1.2


2013-10-13 19:45:18

by Corey Minyard

[permalink] [raw]
Subject: Re: [PATCH] ipmi: remove deprecated IRQF_DISABLED

Thanks, it's in the queue.

-corey

On 10/12/2013 10:59 PM, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 15e4a60..68c5ef5 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1358,7 +1358,7 @@ static int std_irq_setup(struct smi_info *info)
> if (info->si_type == SI_BT) {
> rv = request_irq(info->irq,
> si_bt_irq_handler,
> - IRQF_SHARED | IRQF_DISABLED,
> + IRQF_SHARED,
> DEVICE_NAME,
> info);
> if (!rv)
> @@ -1368,7 +1368,7 @@ static int std_irq_setup(struct smi_info *info)
> } else
> rv = request_irq(info->irq,
> si_irq_handler,
> - IRQF_SHARED | IRQF_DISABLED,
> + IRQF_SHARED,
> DEVICE_NAME,
> info);
> if (rv) {