2013-10-13 06:11:17

by Michael Opdenacker

[permalink] [raw]
Subject: [PATCH] [media] winbond-cir: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <[email protected]>
---
drivers/media/rc/winbond-cir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
index 98bd496..904baf4 100644
--- a/drivers/media/rc/winbond-cir.c
+++ b/drivers/media/rc/winbond-cir.c
@@ -1110,7 +1110,7 @@ wbcir_probe(struct pnp_dev *device, const struct pnp_device_id *dev_id)
}

err = request_irq(data->irq, wbcir_irq_handler,
- IRQF_DISABLED, DRVNAME, device);
+ 0, DRVNAME, device);
if (err) {
dev_err(dev, "Failed to claim IRQ %u\n", data->irq);
err = -EBUSY;
--
1.8.1.2


2013-10-14 10:17:21

by David Härdeman

[permalink] [raw]
Subject: Re: [PATCH] [media] winbond-cir: remove deprecated IRQF_DISABLED

On 2013-10-13 08:11, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker
> <[email protected]>
Acked-by: David Härdeman <[email protected]>
> ---
> drivers/media/rc/winbond-cir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/winbond-cir.c
> b/drivers/media/rc/winbond-cir.c
> index 98bd496..904baf4 100644
> --- a/drivers/media/rc/winbond-cir.c
> +++ b/drivers/media/rc/winbond-cir.c
> @@ -1110,7 +1110,7 @@ wbcir_probe(struct pnp_dev *device, const struct
> pnp_device_id *dev_id)
> }
>
> err = request_irq(data->irq, wbcir_irq_handler,
> - IRQF_DISABLED, DRVNAME, device);
> + 0, DRVNAME, device);
> if (err) {
> dev_err(dev, "Failed to claim IRQ %u\n", data->irq);
> err = -EBUSY;